[turbofan] Fix small redundancy in register allocator per TODO.

[turbofan] Fix small redundancy in register allocator per TODO.

R=mtrofin@chromium.org
BUG=

Committed: https://crrev.com/92b9424ff31f1f754d6277a683a3f4f9792f3e94
Cr-Commit-Position: refs/heads/master@{#33957}

[Mircea Trofin, 2016-02-12 17:43:59]

LGTM, with 2 nits.

https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator.cc:2448: if (loop->rpo_number().ToInt() <=
start_block->rpo_number().ToInt()) break;
Nit: just one if? if (loop == nullptr || loop->rpo_number.... ) { break; }

...see below nit, too.

https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
src/compiler/register-allocator.cc:2450: } while (true);
Nit: personal preference, I'd rather see the exit condition here, rather than
while (true).

[titzer, 2016-02-12 17:52:15]

On 2016/02/12 17:43:59, Mircea Trofin wrote:
> LGTM, with 2 nits.
> 
>
https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
> File src/compiler/register-allocator.cc (right):
> 
>
https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
> src/compiler/register-allocator.cc:2448: if (loop->rpo_number().ToInt() <=
> start_block->rpo_number().ToInt()) break;
> Nit: just one if? if (loop == nullptr || loop->rpo_number.... ) { break; }
> 

Done.

> ...see below nit, too.
> 
>
https://codereview.chromium.org/1690863006/diff/1/src/compiler/register-alloc...
> src/compiler/register-allocator.cc:2450: } while (true);
> Nit: personal preference, I'd rather see the exit condition here, rather than
> while (true).

Yeah, I wanted to do that too, but unfortunately we have to update {block} after
checking the condition, and then go back around the loop.

[titzer, 2016-02-12 17:52:19]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-12 17:52:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/1690863006/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-12 17:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690863006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690863006/20001

[commit-bot: I haz the power, 2016-02-12 18:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 18:15:23]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[titzer, 2016-02-12 18:15:52]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-02-12 18:15:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690863006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690863006/20001

[commit-bot: I haz the power, 2016-02-12 18:17:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-12 18:18:02]

Description was changed from

==========
[turbofan] Fix small redundancy in register allocator per TODO.

R=mtrofin@chromium.org
BUG=
==========

to

==========
[turbofan] Fix small redundancy in register allocator per TODO.

R=mtrofin@chromium.org
BUG=

Committed: https://crrev.com/92b9424ff31f1f754d6277a683a3f4f9792f3e94
Cr-Commit-Position: refs/heads/master@{#33957}
==========

[commit-bot: I haz the power, 2016-02-12 18:18:03]

Patchset 2 (id:??) landed as
https://crrev.com/92b9424ff31f1f754d6277a683a3f4f9792f3e94
Cr-Commit-Position: refs/heads/master@{#33957}