Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 1690853003: Update PIEX version. This should solve the stack buffer overflow issue (Closed)

Created:
4 years, 10 months ago by yujieqin
Modified:
4 years, 10 months ago
Reviewers:
ebrauer, msarett, kjlubick
CC:
adaubert, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update PIEX version and adjust test accrodingly #

Patch Set 3 : rebase #

Patch Set 4 : Update tests #

Patch Set 5 : Revert the change to tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
yujieqin
4 years, 10 months ago (2016-02-11 13:26:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690853003/1
4 years, 10 months ago (2016-02-11 13:26:49 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-11 13:26:50 UTC) #6
kjlubick
lgtm
4 years, 10 months ago (2016-02-11 13:27:34 UTC) #7
ebrauer
lgtm
4 years, 10 months ago (2016-02-11 13:32:22 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6023)
4 years, 10 months ago (2016-02-11 13:36:54 UTC) #10
msarett
Does this match Skia with the version used by Android?
4 years, 10 months ago (2016-02-11 13:55:08 UTC) #11
msarett
Trybot failures look quite similar to: https://codereview.chromium.org/1659873002/ Hopefully fixing this will allow us to land ...
4 years, 10 months ago (2016-02-11 14:03:05 UTC) #12
yujieqin
On 2016/02/11 13:55:08, msarett wrote: > Does this match Skia with the version used by ...
4 years, 10 months ago (2016-02-11 14:27:01 UTC) #13
yujieqin
On 2016/02/11 14:03:05, msarett wrote: > Trybot failures look quite similar to: > https://codereview.chromium.org/1659873002/ > ...
4 years, 10 months ago (2016-02-11 14:27:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690853003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690853003/80001
4 years, 10 months ago (2016-02-17 13:48:35 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 14:12:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/879adccf60eade3b4023c95930d21c67f8f79e97

Powered by Google App Engine
This is Rietveld 408576698