tools/gn/runtime_deps.cc - Issue 1690843002: gn: Add runtime_link_output to tool("solib")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/runtime_deps.cc

Issue 1690843002: gn: Add runtime_link_output to tool("solib") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/runtime_deps.cc

diff --git a/tools/gn/runtime_deps.cc b/tools/gn/runtime_deps.cc

index d82831199fdca5f31529ad73e7d29b955b65e5a3..078bebeee2c822dddda0cc4a7f199ca3e3946560 100644

--- a/tools/gn/runtime_deps.cc

+++ b/tools/gn/runtime_deps.cc

@@ -53,7 +53,7 @@ void AddIfNew(const std::string& str,

// targets. This is weird only for shared libraries.

const OutputFile& GetMainOutput(const Target* target) {

if (target->output_type() == Target::SHARED_LIBRARY)

- return target->link_output_file();

+ return target->runtime_link_output_file();

Nico 2016/02/11 01:55:14 This is the fix for runtime_deps

return target->dependency_output_file();

}

« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »