Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: tools/android/loading/run_sandwich.py

Issue 1690813003: sandwich: Builds a script to pull the metrics from the traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d01
Patch Set: Addresses all review concerns Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/loading/pull_sandwich_metrics_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/loading/run_sandwich.py
diff --git a/tools/android/loading/run_sandwich.py b/tools/android/loading/run_sandwich.py
index 8286c3c1f830dbe5d37b58be32d4f8e7ab1216b9..68ca389e7d97d196851fe337ba39530eeb6adfb6 100755
--- a/tools/android/loading/run_sandwich.py
+++ b/tools/android/loading/run_sandwich.py
@@ -31,6 +31,7 @@ import device_setup
import devtools_monitor
import json
import page_track
+import pull_sandwich_metrics
import tracing
@@ -89,7 +90,7 @@ def _SaveChromeTrace(events, directory, subdirectory):
try:
os.makedirs(target_directory)
with open(filename, 'w') as f:
- json.dump({'traceEvents': events['events'], 'metadata': {}}, f)
+ json.dump({'traceEvents': events['events'], 'metadata': {}}, f, indent=2)
except IOError:
logging.warning('Could not save a trace: %s' % filename)
# Swallow the exception.
@@ -188,7 +189,7 @@ def main():
connection.ClearCache()
page_track.PageTrack(connection)
tracing_track = tracing.TracingTrack(connection,
- categories='blink,cc,netlog,renderer.scheduler,toplevel,v8')
+ categories=pull_sandwich_metrics.CATEGORIES)
connection.SetUpMonitoring()
connection.SendAndIgnoreResponse('Page.navigate', {'url': url})
connection.StartMonitoring()
« no previous file with comments | « tools/android/loading/pull_sandwich_metrics_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698