Issue 1690783002: Set visible ranges for local variables/functions to the ranges of enclosing blocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1690783002: Set visible ranges for local variables/functions to the ranges of enclosing blocks. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Set visible ranges for local variables/functions to the ranges of enclosing blocks. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0f7818600547173e78a423b7cc84ce6cb2b582be

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	pkg/analyzer/lib/dart/element/element.dart	View		1 chunk	+4 lines, -6 lines	1 comment	Download
	M	pkg/analyzer/lib/src/dart/element/builder.dart	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1690783002/diff/1/pkg/analyzer/lib/dart/element/element.dart File pkg/analyzer/lib/dart/element/element.dart (right): https://codereview.chromium.org/1690783002/diff/1/pkg/analyzer/lib/dart/element/element.dart#newcode1467 pkg/analyzer/lib/dart/element/element.dart:1467: * * For a local variable, this is ...

4 years, 10 months ago (2016-02-10 23:08:23 UTC) #2

scheglov

4 years, 10 months ago (2016-02-11 00:17:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f7818600547173e78a423b7cc84ce6cb2b582be.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages