chrome/browser/resources/extensions/extensions.html - Issue 1690773003: [Template expressions] expanding $i18n expressions on webui html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.html

Issue 1690773003: [Template expressions] expanding $i18n expressions on webui html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added colons in comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extensions.html

diff --git a/chrome/browser/resources/extensions/extensions.html b/chrome/browser/resources/extensions/extensions.html

index 155714e11e5fe1a76be8562abab7616375f21db3..35bb5045f8f4852e7e80428f480fd42d4f410845 100644

--- a/chrome/browser/resources/extensions/extensions.html

+++ b/chrome/browser/resources/extensions/extensions.html

@@ -117,8 +117,7 @@

</div>

- <span id="no-extensions-message"

- i18n-content="extensionSettingsNoExtensions"></span>

+ <span id="no-extensions-message">$i18n{extensionSettingsNoExtensions}</span>

Dan Beam 2016/02/13 00:41:22 i understand that you're doing this at least once.

dschuyler 2016/02/13 01:25:40 I've moved the example to a separate CL 1693173002

<span id="suggest-gallery" class="more-extensions-link"

i18n-values=".innerHTML:extensionSettingsSuggestGallery">

</span>

« no previous file with comments | « no previous file | content/browser/webui/web_ui_data_source_impl.h » ('j') | no next file with comments »