Issue 16907006: buildbots: only store/upload GM results we haven't seen before, to save time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16907006: buildbots: only store/upload GM results we haven't seen before, to save time (Closed)

Created:
7 years, 6 months ago by epoger

Modified:
7 years, 6 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/buildbot/

Visibility:
Public.

More Reviews

Description

buildbots: only store/upload GM results we haven't seen before, to save time Depends on https://codereview.chromium.org/17552012/ ('GM: add --missingExpectationsPath option, similar to --mismatchPath') R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9726

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	slave/skia_slave_scripts/run_gm.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

Committed patchset #1 manually as r9726 (presubmit successful).

7 years, 6 months ago (2013-06-21 18:28:25 UTC) #3

epoger

7 years, 6 months ago (2013-06-21 18:41:59 UTC) #4

Message was sent while issue was closed.

Cool, this is working as expected so far...

BEFORE:
http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Deb...
Uploading 419 GM-actual files to Google Storage...
elapsedTime=182.343277

AFTER:
http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Deb...
Uploading 156 GM-actual files to Google Storage...
elapsedTime=66.220067


... and the difference should be more pronounced on Android builders, since we
don't have to copy so many files over to the host machine anymore.

We can get further wins by checking in more baselines (which is a win in lots of
ways!), reducing the number of files written by --missingExpectationsPath .

Expand Messages | Collapse Messages