Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1690683002: added some missing static modifiers (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/debugger/SkDrawCommand.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/json/SkJSONCanvas.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 10 months ago (2016-02-10 19:43:15 UTC) #3
joshualitt
On 2016/02/10 19:43:15, ethannicholas wrote: lgtm
4 years, 10 months ago (2016-02-10 19:44:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690683002/1
4 years, 10 months ago (2016-02-10 19:44:45 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 20:10:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd3dae8a970d6f4dea85729c124eeb4e89d4ab8a

Powered by Google App Engine
This is Rietveld 408576698