Reland #1 Remove the is_loading_ field from WebContentsImpl

Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d3cd115cc83134b6a62c279520e366a0abc79636
Cr-Commit-Position: refs/heads/master@{#375200}

[clamy, 2016-02-11 13:42:53]

Description was changed from

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
==========

to

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-02-11 15:15:28]

Description was changed from

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-02-11 15:15:28]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-02-11 15:17:17]

@nasko: PTAL - this is the reland of the patch that was submitted yesterday.
I found the issue with the test: in some interleaving of IPCs, we would get a
DidStopLoading from an RFH that is pending deletion while the current RFH is not
navigating, which would result in an extraneous DidStopLoading being fired.

[nasko, 2016-02-11 16:33:45]

https://codereview.chromium.org/1690653003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1690653003/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:1716: : this ==
frame_tree_node_->render_manager()->pending_frame_host());
This seems rather hard to read. Can we find a simpler way to write it?
Alternatively, why can't we consult the RFH state? If I got it right, the issue
was receiving IPC while in pending swap/deletion state, right?

[clamy, 2016-02-12 12:25:42]

https://codereview.chromium.org/1690653003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1690653003/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:1716: : this ==
frame_tree_node_->render_manager()->pending_frame_host());
On 2016/02/11 16:33:45, nasko wrote:
> This seems rather hard to read. Can we find a simpler way to write it?
> Alternatively, why can't we consult the RFH state? If I got it right, the
issue
> was receiving IPC while in pending swap/deletion state, right?

Done.

[nasko, 2016-02-12 15:03:46]

LGTM

[clamy, 2016-02-12 15:14:33]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2016-02-12 15:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690653003/40001

[commit-bot: I haz the power, 2016-02-12 18:22:19]

Description was changed from

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-02-12 18:22:20]

Committed patchset #3 (id:40001)

[lazyboy, 2016-02-13 00:15:18]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1696973002/ by lazyboy@chromium.org.

The reason for reverting is: A bunch of SessionHistoryTest.* tests started being
flaky on Cast Linux bot
after the CL landed.

See below for details:

Before the CL I've checked 5 builds that never had any failure:
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18670
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18669
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18668
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18667

After/at the CL a lot of the builds either completely failed and passed on
retry:

https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18671
SessionHistoryTest.FrameBackForward

https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18672
SessionHistoryTest.FragmentBackForward
SessionHistoryTest.HistoryLength

https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18677
SessionHistoryTest.FragmentBackForward

https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18678
SessionHistoryTest.FragmentBackForward

https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/18679
SessionHistoryTest.BasicBackForward
SessionHistoryTest.HistoryLength.

[commit-bot: I haz the power, 2016-02-16 22:43:41]

Description was changed from

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland #1 Remove the is_loading_ field from WebContentsImpl

The CL was reverted since it introduced flakyness on the
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs test on the
ChromiumOS dbg bot.

Original commit message:
This CL removes the is_loading_ field from WebContents, in favor of only
tracking the loading state through the FrameTree. Currently the loading state
is tracked in both, leading to more complexity in the code.

BUG=571887, 298193
TBR=rockot@chromium.org,nick@chromium.org,carlosk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d3cd115cc83134b6a62c279520e366a0abc79636
Cr-Commit-Position: refs/heads/master@{#375200}
==========

[commit-bot: I haz the power, 2016-02-16 22:43:42]

Patchset 3 (id:??) landed as
https://crrev.com/d3cd115cc83134b6a62c279520e366a0abc79636
Cr-Commit-Position: refs/heads/master@{#375200}