Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1690633003: SkNx refactoring (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkNx refactoring - add back Sk4i typedef - define SSE casts in terms of Sk4i * uint8 <-> float becomes uint8 <-> int <-> float * uint16 <-> float becomes uint16 <-> int <-> float This has the nice side effect of specializing uint8 <-> int and uint16 <-> int, which are useful in their own right. There are many cast specializations now, some of which call each other. I have tried to arrange them in some sort of sensible order, subject to the constraint that those called must precede those who call. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690633003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/c1eb311f4e98934476f1b2ad5d6de772cf140d60

Patch Set 1 #

Patch Set 2 : give some sort of order #

Patch Set 3 : tweaks and comments #

Patch Set 4 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -33 lines) Patch
M src/core/SkNx.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 2 3 1 chunk +48 lines, -33 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633003/20001
4 years, 10 months ago (2016-02-11 03:41:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633003/40001
4 years, 10 months ago (2016-02-11 03:58:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633003/60001
4 years, 10 months ago (2016-02-11 04:00:03 UTC) #8
mtklein_C
4 years, 10 months ago (2016-02-11 04:21:28 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 04:34:02 UTC) #12
herb_g
lgtm
4 years, 10 months ago (2016-02-11 15:20:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633003/60001
4 years, 10 months ago (2016-02-11 15:58:53 UTC) #15
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-11 16:00:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633003/60001
4 years, 10 months ago (2016-02-11 16:08:44 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c1eb311f4e98934476f1b2ad5d6de772cf140d60
4 years, 10 months ago (2016-02-11 16:10:25 UTC) #21
mtklein
4 years, 10 months ago (2016-02-12 21:54:18 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1696903002/ by mtklein@google.com.

The reason for reverting is: Precautionary revert for chromium:586487.

Powered by Google App Engine
This is Rietveld 408576698