Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 169063004: Remove pp_ifdef from grd files in ash/. (Closed)

Created:
6 years, 10 months ago by newt (away)
Modified:
6 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Remove pp_ifdef from grd files in ash/. Generated using: > cd src/ash > git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g" BUG=343235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_strings.grd View 5 chunks +12 lines, -12 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
PTAL
6 years, 10 months ago (2014-02-19 01:00:17 UTC) #1
oshima
lgtm
6 years, 10 months ago (2014-02-19 05:45:11 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 10 months ago (2014-02-19 17:03:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/169063004/1
6 years, 10 months ago (2014-02-19 17:05:47 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:39:52 UTC) #5
Message was sent while issue was closed.
Change committed as 252101

Powered by Google App Engine
This is Rietveld 408576698