Cast: make global_instance_ more strict

content/public/test/mock_render_thread.cc

Index: content/public/test/mock_render_thread.cc
diff --git a/content/public/test/mock_render_thread.cc b/content/public/test/mock_render_thread.cc
index ec7ead85a693bffebaa1b68475226b833ad0725d..99194e19e1c9f817e14c45fe20d274e93396b604 100644
--- a/content/public/test/mock_render_thread.cc
+++ b/content/public/test/mock_render_thread.cc
@@ -26,6 +26,11 @@ MockRenderThread::MockRenderThread()
 }
 
 MockRenderThread::~MockRenderThread() {
+  while (!filters_.empty()) {
+    scoped_refptr<IPC::ChannelProxy::MessageFilter> filter = filters_.back();
+    filters_.pop_back();
+    filter->OnChannelClosing();

[acolwell GONE FROM CHROMIUM, 2014/02/19 00:11:24]

I think this should also include filter->OnFilterRemoved(). I think we should be
emulating the ChannelProxy::Context::OnChannelClosed() code here
https://code.google.com/p/chromium/codesearch#chromium/src/ipc/ipc_channel_pr...

I'm on the fence about the OnChannelClosing() call you've added here though
because this class does not appear to be emulating the OnChannelConnected() call
so I'm not sure of the OnChannelClosing() call makes sense here.

[hubbe, 2014/02/19 00:29:51]

Better?

+  }
 }
 
 void MockRenderThread::VerifyRunJavaScriptMessageSend(