Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1690613002: added JSON support for various lesser-used features (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : set send_binaries back to false #

Patch Set 3 : fixed minor mistakes leading to a build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -50 lines) Patch
M tools/debugger/SkDrawCommand.h View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 22 chunks +272 lines, -48 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ethannicholas
4 years, 10 months ago (2016-02-10 16:56:47 UTC) #3
joshualitt
On 2016/02/10 16:56:47, ethannicholas wrote: lgtm
4 years, 10 months ago (2016-02-10 17:40:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690613002/20001
4 years, 10 months ago (2016-02-10 17:41:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/6057)
4 years, 10 months ago (2016-02-10 17:42:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690613002/40001
4 years, 10 months ago (2016-02-10 21:20:46 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 22:05:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1446a9a67ab30cd93e3e9c6210daec86b062e234

Powered by Google App Engine
This is Rietveld 408576698