Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/BUILD.gn

Issue 1690603003: Allow load_library_from_apk to be set via gn args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 0b12617e24795fa4243ebed50e5e047efed9754e..7a051ef5bb051fb5e84af7a83f47854471667c12 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -471,14 +471,6 @@ template("chrome_public_apk_tmpl_shared") {
native_lib_version_rule = "//build/util:chrome_version_json"
- # Only attempt loading the library from the APK for 64 bit devices
- # until the number of 32 bit devices which don't support this
- # approach falls to a minimal level - http://crbug.com/390618.
- if (chromium_linker_supported &&
- (target_cpu == "arm64" || target_cpu == "x64")) {
- load_library_from_apk = chrome_public_apk_load_library_from_apk
- }
-
deps += [
":chrome_java",
":chrome_public_apk_assets",
« no previous file with comments | « build/config/android/rules.gni ('k') | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698