Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1690603003: Allow load_library_from_apk to be set via gn args (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow load_library_from_apk to be set via gn args There were already gn args for it and its peers: - chrome_public_apk_use_chromium_linker - chrome_public_apk_use_relocation_packer - chrome_public_apk_load_library_from_apk However, they were only able to disable the options. With this change, they are able to both enable and disable. The main use-case is to allow building with load_library_from_apk for 32-bit arm when testing locally. BUG=none Committed: https://crrev.com/0a2180186638ce097261ee94509b56aaad0f9c27 Cr-Commit-Position: refs/heads/master@{#375247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M build/config/android/rules.gni View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 2 chunks +19 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
🐸🐸🐸
4 years, 10 months ago (2016-02-11 01:11:54 UTC) #2
agrieve
On 2016/02/11 01:11:54, agrieve wrote: > 🐸🐸🐸 nudge
4 years, 10 months ago (2016-02-12 15:16:29 UTC) #3
Ted C
lgtm
4 years, 10 months ago (2016-02-12 19:39:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690603003/1
4 years, 10 months ago (2016-02-12 19:47:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 20:37:36 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:44:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a2180186638ce097261ee94509b56aaad0f9c27
Cr-Commit-Position: refs/heads/master@{#375247}

Powered by Google App Engine
This is Rietveld 408576698