components/ssl_errors/error_classification.h - Issue 1690593002: Reduce memory use of GetLevenshteinDistance() by almost 50%

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ssl_errors/error_classification.h

Issue 1690593002: Reduce memory use of GetLevenshteinDistance() by almost 50% (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ssl_errors/error_classification.h

diff --git a/components/ssl_errors/error_classification.h b/components/ssl_errors/error_classification.h

index c7ce540e5ffc767a05d4a76f5dc2b4070117ece9..986b435d7ed9ac5a0a2241746c0b00ccf0431afe 100644

--- a/components/ssl_errors/error_classification.h

+++ b/components/ssl_errors/error_classification.h

@@ -63,6 +63,9 @@ bool GetWWWSubDomainMatch(const GURL& request_url,

const std::vector<std::string>& dns_names,

std::string* www_match_host_name);

+// Exposed for testing.

+size_t GetLevenshteinDistance(const std::string& str1, const std::string& str2);

felt 2016/02/11 00:10:42 Could you move this into the "helper methods" sect

// Method for recording results. -----------------------------------------------

void RecordUMAStatistics(bool overridable,

« no previous file with comments | « no previous file | components/ssl_errors/error_classification.cc » ('j') | no next file with comments »