Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/table/table_view.cc ('k') | ui/views/controls/textfield/textfield_unittest.cc » ('j') | ui/views/view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 2d16153419fdd89eb07b692851f25b9d4e3d0cb2..e7cb64d64cba0a02e9b6161d5d7f98f52775ea0e 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -293,7 +293,10 @@ Textfield::Textfield()
set_drag_controller(this);
GetRenderText()->SetFontList(GetDefaultFontList());
SetBorder(std::unique_ptr<Border>(new FocusableBorder()));
- SetFocusable(true);
+
+ // On Mac, only textfields and list controls are focusable by default. Hence
+ // use ALWAYS focus behavior.
+ SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
if (ViewsDelegate::GetInstance()) {
password_reveal_duration_ =
« no previous file with comments | « ui/views/controls/table/table_view.cc ('k') | ui/views/controls/textfield/textfield_unittest.cc » ('j') | ui/views/view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698