ui/views/controls/menu/menu_controller_unittest.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller_unittest.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller_unittest.cc

diff --git a/ui/views/controls/menu/menu_controller_unittest.cc b/ui/views/controls/menu/menu_controller_unittest.cc

index c52e8be1bb31a2096d8efa98363b6b72f3f56606..adb1d247c080329cf6a3eb58acf356e9a4c92df4 100644

--- a/ui/views/controls/menu/menu_controller_unittest.cc

+++ b/ui/views/controls/menu/menu_controller_unittest.cc

@@ -457,7 +457,8 @@ class MenuControllerTest : public ViewsTestBase {

for (int i = 0; i < 3; ++i) {

LabelButton* button =

new LabelButton(nullptr, base::ASCIIToUTF16("Label"));

- button->SetFocusable(true);

+ // This is an in-menu button. Hence it must be always focusable.

+ button->SetFocusBehavior(View::FocusBehavior::ALWAYS);

item_view->AddChildView(button);

}

menu_item()->GetSubmenu()->ShowAt(owner(), menu_item()->bounds(), false);