Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: ui/views/controls/button/button.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/button.cc
diff --git a/ui/views/controls/button/button.cc b/ui/views/controls/button/button.cc
index 92603dd145955a3113d250a27b1e6f66612b83cb..667afbeff394158de137f1ae1d3dec550f7f4b00 100644
--- a/ui/views/controls/button/button.cc
+++ b/ui/views/controls/button/button.cc
@@ -24,6 +24,16 @@ Button::ButtonState Button::GetButtonStateFrom(ui::NativeTheme::State state) {
return Button::STATE_NORMAL;
}
+// static
+void Button::ConfigureDefaultFocus(Button* button) {
+// On Mac, buttons are focusable only in full keyboard access mode.
+#if defined(OS_MACOSX)
+ button->SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY);
+#else
+ button->SetFocusBehavior(FocusBehavior::ALWAYS);
+#endif
+}
+
////////////////////////////////////////////////////////////////////////////////
// Button, public:
@@ -64,7 +74,7 @@ void Button::GetAccessibleState(ui::AXViewState* state) {
Button::Button(ButtonListener* listener)
: listener_(listener),
tag_(-1) {
- SetAccessibilityFocusable(true);
+ SetFocusBehavior(views::View::FocusBehavior::ACCESSIBLE_ONLY);
}
void Button::NotifyClick(const ui::Event& event) {

Powered by Google App Engine
This is Rietveld 408576698