chrome/browser/ui/views/location_bar/location_icon_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc

index f1b4fc8d396218d5b32f8973a8dcc5f903ba2775..c8c4530c02ec89bfa87b1e69bcab39804857cd95 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc

@@ -58,7 +58,12 @@ LocationIconView::LocationIconView(const gfx::FontList& font_list,

suppress_mouse_released_action_(false),

location_bar_(location_bar) {

set_id(VIEW_ID_LOCATION_ICON);

- SetFocusable(true);

+#if defined(OS_MACOSX)

+ SetFocusBehavior(views::View::FocusBehavior::ACCESSIBLE_ONLY);

+#else

+ SetFocusBehavior(views::View::FocusBehavior::ALWAYS);

+#endif

SetBackground(false);

}