chrome/browser/ui/views/frame/browser_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 9d6df848b176520ee4dc36a8beed6b3023348469..40eee813501932134bfbc2b7ea84a6234a3a93f6 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1937,7 +1937,8 @@ void BrowserView::Layout() {

views::View::Layout();

// TODO(jamescook): Why was this in the middle of layout code?

- toolbar_->location_bar()->omnibox_view()->SetFocusable(IsToolbarVisible());

+ toolbar_->location_bar()->omnibox_view()->SetFocusBehavior(

+ IsToolbarVisible() ? FocusBehavior::ALWAYS : FocusBehavior::NEVER);

}

void BrowserView::ViewHierarchyChanged(