chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc ('k') | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | ui/views/view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

index 5d3ac9b6d84f9eabc5e4f4c44de3dd6aff36e079..a744849cdcfb69a827b21e22394ec653b7c17eef 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

@@ -52,7 +52,7 @@ BookmarkBarInstructionsView::BookmarkBarInstructionsView(

import_link_ = new views::Link(

l10n_util::GetStringUTF16(IDS_BOOKMARK_BAR_IMPORT_LINK));

// We don't want the link to alter tab navigation.

- import_link_->SetFocusable(false);

+ import_link_->SetFocusBehavior(views::View::FocusBehavior::NEVER);

import_link_->set_listener(this);

import_link_->set_context_menu_controller(this);

import_link_->SetAutoColorReadabilityEnabled(false);