ash/shelf/shelf_button.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_button.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_button.cc

diff --git a/ash/shelf/shelf_button.cc b/ash/shelf/shelf_button.cc

index 7a805bd99388f9bac7de93d1392259e550d27104..ec707c2673b98397928c12cce88e3bc1ac60d1ce 100644

--- a/ash/shelf/shelf_button.cc

+++ b/ash/shelf/shelf_button.cc

@@ -228,7 +228,7 @@ ShelfButton::ShelfButton(ShelfView* shelf_view)

bar_(new BarView(shelf_view->shelf())),

state_(STATE_NORMAL),

destroyed_flag_(nullptr) {

- SetAccessibilityFocusable(true);

+ SetFocusBehavior(views::View::FocusBehavior::ACCESSIBLE_ONLY);

const gfx::ShadowValue kShadows[] = {

gfx::ShadowValue(gfx::Vector2d(0, 2), 0, SkColorSetARGB(0x1A, 0, 0, 0)),