ui/views/cocoa/bridged_native_widget.mm - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget.mm

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Make patch smaller temporarily. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_native_widget.mm

diff --git a/ui/views/cocoa/bridged_native_widget.mm b/ui/views/cocoa/bridged_native_widget.mm

index 6f5dec0f96864ede56c8a7cf940de5ebf964aa92..e254bcc5107ef0295d8f251d167d3d4b6c58ab48 100644

--- a/ui/views/cocoa/bridged_native_widget.mm

+++ b/ui/views/cocoa/bridged_native_widget.mm

@@ -758,6 +758,9 @@ void BridgedNativeWidget::OnWindowKeyStatusChangedTo(bool is_key) {

if ([window_ contentView] == [window_ firstResponder]) {

if (is_key) {

widget->OnNativeFocus();

+ // Explicitly set the keyboard accessibility state on regaining key

+ // window status.

+ [bridged_view_ updateFullKeyboardAccess];

widget->GetFocusManager()->RestoreFocusedView();

} else {

widget->OnNativeBlur();