Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ui/views/focus/focus_search.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_search.cc
diff --git a/ui/views/focus/focus_search.cc b/ui/views/focus/focus_search.cc
index a7ede3b0bf3d044666fbcdb9df23a3d45017f57b..f4d77002f5885342c7c1fee32142ef6df74f7112 100644
--- a/ui/views/focus/focus_search.cc
+++ b/ui/views/focus/focus_search.cc
@@ -98,11 +98,15 @@ bool FocusSearch::IsViewFocusableCandidate(View* v, int skip_group_id) {
v->GetGroup() != skip_group_id);
}
+// On Mac, we also need to read system preferences for "Full Keyboard Access" to
tapted 2016/02/12 02:56:45 Can we instead expose the |accessibility_mode_| da
karandeepb 2016/02/22 07:15:37 Done. Instead of setting the accessibility mode on
+// decide whether accessibility mode should be enabled or not.
+#if !defined(OS_MACOSX)
bool FocusSearch::IsFocusable(View* v) {
if (accessibility_mode_)
return v && v->IsAccessibilityFocusable();
return v && v->IsFocusable();
}
+#endif
View* FocusSearch::FindSelectedViewForGroup(View* view) {
if (view->IsGroupFocusTraversable() ||

Powered by Google App Engine
This is Rietveld 408576698