ui/views/touchui/touch_selection_menu_runner_views.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_selection_menu_runner_views.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/touchui/touch_selection_menu_runner_views.cc

diff --git a/ui/views/touchui/touch_selection_menu_runner_views.cc b/ui/views/touchui/touch_selection_menu_runner_views.cc

index d5928a3353dd44ab4d5e93d209a3e971b115d60b..14d74abd0bd614bf1837c47cf72f5211a99edeb2 100644

--- a/ui/views/touchui/touch_selection_menu_runner_views.cc

+++ b/ui/views/touchui/touch_selection_menu_runner_views.cc

@@ -20,6 +20,7 @@

#include "ui/views/controls/button/button.h"

#include "ui/views/controls/button/label_button.h"

#include "ui/views/layout/box_layout.h"

+#include "ui/views/style/platform_style.h"

namespace views {

namespace {

@@ -159,7 +160,7 @@ Button* TouchSelectionMenuRunnerViews::Menu::CreateButton(

gfx::RemoveAcceleratorChar(title, '&', nullptr, nullptr);

LabelButton* button = new LabelButton(this, label);

button->SetMinSize(gfx::Size(kMenuButtonMinWidth, kMenuButtonMinHeight));

- button->SetFocusable(true);

+ PlatformStyle::SetControlStyleFocus(button);

button->set_request_focus_on_press(false);

const gfx::FontList& font_list =

ui::ResourceBundle::GetSharedInstance().GetFontList(