MacViews: Implement Full Keyboard Access.

ui/views/view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_VIEW_H_
 #define UI_VIEWS_VIEW_H_
 
 #include <stddef.h>
 
 #include <algorithm>
@@ skipping 733 matching lines @@
   // Overridden from AcceleratorTarget:
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
 
   // Returns whether accelerators are enabled for this view. Accelerators are
   // enabled if the containing widget is visible and the view is enabled() and
   // IsDrawn()
   bool CanHandleAccelerators() const override;
 
   // Focus ---------------------------------------------------------------------
 
+  enum FocusBehavior {

[tapted, 2016/03/15 05:05:32]

enums are always declared before methods in the class declaration order, so this
should be at the top.

Also I think we should use an `enum class` and refer to these as
FocusBehaviour::ALWAYS  (otherwise we would prefix like FOCUS_ALWAYS, since
ALWAYS/NEVER are a bit too vague to be in the subclass' default namespace)

[karandeepb, 2016/03/17 07:24:47]

Done.

+    ALWAYS,  // Use when the view is to be focusable both in default and full

[tapted, 2016/03/15 05:05:32]

nit: if we can't fit in a line, we usually just comment above and leave a blank
line after the declaration

[karandeepb, 2016/03/17 07:24:47]

Done.

+             // keyboard access mode.
+    NEVER,   // Default.
+    ACCESSIBLE_ONLY,  // Use when the view is to be made focusable only during
+                      // full keyboard mode.
+    CONTROL  // Use for controls. On Mac, this is the same as ACCESSIBLE_ONLY

[tapted, 2016/03/15 05:05:32]

nit: CONTROL,

[karandeepb, 2016/03/17 07:24:47]

Done.

+             // mode, while on other platforms it corresponds to ALWAYS.
+  };
+
   // Returns whether this view currently has the focus.
   virtual bool HasFocus() const;
 
   // Returns the view that should be selected next when pressing Tab.
   View* GetNextFocusableView();
   const View* GetNextFocusableView() const;
 
   // Returns the view that should be selected next when pressing Shift-Tab.
   View* GetPreviousFocusableView();
 
   // Sets the component that should be selected next when pressing Tab, and
   // makes the current view the precedent view of the specified one.
   // Note that by default views are linked in the order they have been added to
   // their container. Use this method if you want to modify the order.
   // IMPORTANT NOTE: loops in the focus hierarchy are not supported.
   void SetNextFocusableView(View* view);
 
+  // Sets |focusable_| and |accessibility_focusable_| corresponding to the given
+  // |focus_behavior|.
+  void SetFocusBehavior(FocusBehavior focus_behavior);
+
   // Sets whether this view is capable of taking focus. It will clear focus if
   // the focused view is set to be non-focusable.
   // Note that this is false by default so that a view used as a container does
   // not get the focus.
+  // TODO(karandeepb): Make private.
   void SetFocusable(bool focusable);
 
   // Returns true if this view is |focusable_|, |enabled_| and drawn.
   bool IsFocusable() const;
 
   // Return whether this view is focusable when the user requires full keyboard
   // access, even though it may not be normally focusable.
   bool IsAccessibilityFocusable() const;
 
   // Set whether this view can be made focusable if the user requires
   // full keyboard access, even though it's not normally focusable. It will
   // clear focus if the focused view is set to be non-focusable.
   // Note that this is false by default.
+  // TODO(karandeepb): Make private.
   void SetAccessibilityFocusable(bool accessibility_focusable);
 
   // Convenience method to retrieve the FocusManager associated with the
   // Widget that contains this view.  This can return NULL if this view is not
   // part of a view hierarchy with a Widget.
   virtual FocusManager* GetFocusManager();
   virtual const FocusManager* GetFocusManager() const;
 
   // Request keyboard focus. The receiving view will become the focused view.
   virtual void RequestFocus();
@@ skipping 772 matching lines @@
   // Belongs to this view, but it's reference-counted on some platforms
   // so we can't use a scoped_ptr. It's dereferenced in the destructor.
   NativeViewAccessibility* native_view_accessibility_;
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_VIEW_H_