MacViews: Implement Full Keyboard Access.

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 1183 matching lines @@
 View* View::GetPreviousFocusableView() {
   return previous_focusable_view_;
 }
 
 void View::SetNextFocusableView(View* view) {
   if (view)
     view->previous_focusable_view_ = this;
   next_focusable_view_ = view;
 }
 
+void View::SetFocusBehavior(FocusBehavior focus_behavior) {
+  switch (focus_behavior) {
+    case ALWAYS:
+      SetFocusable(true);
+      SetAccessibilityFocusable(true);
+      break;
+    case NEVER:
+      SetFocusable(false);
+      SetAccessibilityFocusable(false);
+      break;
+    case ACCESSIBLE_ONLY:
+      SetFocusable(false);
+      SetAccessibilityFocusable(true);
+      break;
+    case CONTROL:
+#if defined(OS_MACOSX)

[tapted, 2016/03/15 05:05:32]

This might be more readable with something like (at the top)

#if defined(OS_MACOSX)
if (focus_behaviour == CONTROL)
  focus_behavior = ACCESSIBLE_ONLY;
#endif

[karandeepb, 2016/03/17 07:24:47]

Done.

+      SetFocusable(false);
+      SetAccessibilityFocusable(true);
+#else
+      SetFocusable(true);
+      SetAccessibilityFocusable(true);
+#endif
+      break;
+  }
+}
+
 void View::SetFocusable(bool focusable) {
   if (focusable_ == focusable)
     return;
 
   focusable_ = focusable;
   AdvanceFocusIfNecessary();
 }
 
 bool View::IsFocusable() const {
   return focusable_ && enabled_ && IsDrawn();
@@ skipping 1214 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views