MacViews: Implement Full Keyboard Access.

ui/views/focus/focus_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_FOCUS_FOCUS_MANAGER_H_
 #define UI_VIEWS_FOCUS_FOCUS_MANAGER_H_
 
 #include <list>
 #include <map>
 
@@ skipping 183 matching lines @@
   // attached to the window hierarchy anymore.
   void ValidateFocusedView();
 
   // Stores the focused view. Used when the widget loses activation.
   // |clear_native_focus| indicates whether this should invoke ClearFocus().
   // Typically |true| should be passed in.
   void StoreFocusedView(bool clear_native_focus);
 
   // Restore the view saved with a previous call to StoreFocusedView(). Used
   // when the widget becomes active. Returns true when the previous view was
-  // successfully refocused - otherwise false.
+  // successfully refocused - otherwise false. In case, the stored view is no
+  // longer focusable, it advances focus and returns false.
   bool RestoreFocusedView();
 
   // Sets the |view| to be restored when calling RestoreFocusView. This is used
   // to set where the focus should go on restoring a Window created without
   // focus being set.
   void SetStoredFocusView(View* view);
 
   // Returns the View that either currently has focus, or if no view has focus
   // the view that last had focus.
   View* GetStoredFocusView();
@@ skipping 103 matching lines @@
   // |starting_view| is NULL |starting_widget| is consuled to determine which
   // Widget to start from. See
   // WidgetDelegate::ShouldAdvanceFocusToTopLevelWidget() for details. If both
   // |starting_view| and |starting_widget| are NULL, traversal starts at
   // |widget_|.
   View* GetNextFocusableView(View* starting_view,
                              Widget* starting_widget,
                              bool reverse,
                              bool dont_loop);
 
+  // Returns keyboard_accessibility_.
+  bool IsKeyboardAccessibilityEnabled() { return keyboard_accessibility_; }

[tapted, 2016/02/23 03:01:19]

for accessors like this, we just do

bool keyboard_accessibility() const { return keyboard_accessibility_; }

it doesn't need a comment

[karandeepb, 2016/03/15 02:19:50]

Done.

+
+  // Updates keyboard_accessibility_ to the given value and advances focus if

[tapted, 2016/02/23 03:01:19]

keyboard_accessibility_ -> |keyboard_accessibility_|

[karandeepb, 2016/03/15 02:19:50]

Done.

+  // necessary.
+  void SetKeyboardAccessibility(bool keyboard_accessibility);
+
  private:
   // Returns the focusable view found in the FocusTraversable specified starting
   // at the specified view. This traverses down along the FocusTraversable
   // hierarchy.
   // Returns NULL if no focusable view were found.
   View* FindFocusableView(FocusTraversable* focus_traversable,
                           View* starting_view,
                           bool reverse);
 
   // Process arrow key traversal. Returns true if the event has been consumed
   // and should not be processed further.
   bool ProcessArrowKeyTraversal(const ui::KeyEvent& event);
 
+  // Returns true if a view is not NULL and is focusable (checking

[tapted, 2016/02/23 03:01:20]

NULL -> null

[karandeepb, 2016/03/15 02:19:51]

Done.

+  // IsAccessibilityFocusable() if keyboard_accessibility_ is true).

[tapted, 2016/02/23 03:01:20]

keyboard_accessibility_ -> |keyboard_accessibility_|

[karandeepb, 2016/03/15 02:19:50]

Done.

+  bool IsFocusable(View* view);

[tapted, 2016/02/23 03:01:19]

const method?

[karandeepb, 2016/03/15 02:19:50]

Done.

+
   // Whether arrow key traversal is enabled.
   static bool arrow_key_traversal_enabled_;
 
   // The top-level Widget this FocusManager is associated with.
   Widget* widget_;
 
   // The object which handles an accelerator when |accelerator_manager_| doesn't
   // handle it.
   scoped_ptr<FocusManagerDelegate> delegate_;
 
@@ skipping 12 matching lines @@
 
   // The reason why the focus most recently changed.
   FocusChangeReason focus_change_reason_;
 
   // The list of registered FocusChange listeners.
   base::ObserverList<FocusChangeListener, true> focus_change_listeners_;
 
   // See description above getter.
   bool is_changing_focus_;
 
+  // This is true if full keyboard accessibility is needed and you want to

[tapted, 2016/02/23 03:01:20]

`you want to check` sounds funny. Perhaps `FocusSearch should check`

[karandeepb, 2016/03/15 02:19:50]

Done.

+  // check IsAccessibilityFocusable(), rather than IsFocusable(). This can be
+  // set depending on platform constraints, for example, on Mac, this is true

[tapted, 2016/02/23 03:01:20]

`constraints, for example,` -> `constraints. For Example,`

[karandeepb, 2016/03/15 02:19:50]

Done.

+  // when Full Keyboard Access mode is on. FocusSearch uses this in addition to
+  // its own accessibility mode, which handles accessibility at the view level.
+  // Default value is false.
+  bool keyboard_accessibility_;

[tapted, 2016/02/23 03:01:20]

maybe `keyboard_accessible_` is a better name

[karandeepb, 2016/03/15 02:19:50]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(FocusManager);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_FOCUS_FOCUS_MANAGER_H_