MacViews: Implement Full Keyboard Access.

ui/views/controls/link.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/link.h"
 
 #include "build/build_config.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/events/event.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/font_list.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/native_cursor.h"
+#include "ui/views/style/platform_style.h"
 
 namespace views {
 
 const char Link::kViewClassName[] = "Link";
 
 Link::Link() : Link(base::string16()) {}
 
 Link::Link(const base::string16& title)
     : Label(title),
       requested_enabled_color_(gfx::kPlaceholderColor),
@@ skipping 119 matching lines @@
   SchedulePaint();
 }
 
 void Link::SetFontList(const gfx::FontList& font_list) {
   Label::SetFontList(font_list);
   RecalculateFont();
 }
 
 void Link::SetText(const base::string16& text) {
   Label::SetText(text);
+
   // Disable focusability for empty links.  Otherwise Label::GetInsets() will

[tapted, 2016/02/23 03:01:19]

This comment about Label::GetInsets() concerns me. Does Label::GetInsets() need
to be changed to use IsAccessibilityFocusable()?  (or, perhaps neater, should
the text.empty() check move to Label::GetInsets()? then leave off the
SetAccessibilityFocusable(false); calls 

[karandeepb, 2016/03/15 02:19:50]

Yeah GetInsets() is currently using focusable() to determine whether to add
insets or not. This way insets won't be added to links while in Full Keyboard
access mode on Mac. This can be corrected by using IsAccessibilityFocusable().
However, using focusable() instead of IsFocusable() seems to have been a
conscious decision -  https://codereview.chromium.org/111023004/#msg4

   // give them an unconditional 1-px. inset on every side to allow for a focus
   // border, when in this case we probably wanted zero width.
-  SetFocusable(!text.empty());
+  if (!text.empty()) {
+    PlatformStyle::SetControlStyleFocus(this);
+  } else {
+    SetFocusable(false);
+    SetAccessibilityFocusable(false);
+  }
 }
 
 void Link::OnNativeThemeChanged(const ui::NativeTheme* theme) {
   Label::SetEnabledColor(GetEnabledColor());
   SetDisabledColor(
       theme->GetSystemColor(ui::NativeTheme::kColorId_LinkDisabled));
 }
 
 void Link::SetEnabledColor(SkColor color) {
   requested_enabled_color_set_ = true;
@@ skipping 15 matching lines @@
 }
 
 void Link::Init() {
   listener_ = NULL;
   pressed_ = false;
   underline_ = true;
   RecalculateFont();
 
   // Label::Init() calls SetText(), but if that's being called from Label(), our
   // SetText() override will not be reached (because the constructed class is
-  // only a Label at the moment, not yet a Link).  So so the set_focusable()
-  // call explicitly here.
-  SetFocusable(!text().empty());
+  // only a Label at the moment, not yet a Link).  So explicitly set
+  // focusability here.
+  if (!text().empty()) {

[tapted, 2016/02/23 03:01:19]

This could also just call SetText again, but we should be able to simplify it so
there's not as much copy-paste

[karandeepb, 2016/03/15 02:19:50]

Done.

+    PlatformStyle::SetControlStyleFocus(this);
+  } else {
+    SetFocusable(false);
+    SetAccessibilityFocusable(false);
+  }
 }
 
 void Link::SetPressed(bool pressed) {
   if (pressed_ != pressed) {
     pressed_ = pressed;
     Label::SetEnabledColor(GetEnabledColor());
     RecalculateFont();
     SchedulePaint();
   }
 }
@@ skipping 19 matching lines @@
   }
 
   if (!requested_pressed_color_set_ && GetNativeTheme())
     return GetNativeTheme()->GetSystemColor(
         ui::NativeTheme::kColorId_LinkPressed);
 
   return requested_pressed_color_;
 }
 
 }  // namespace views