MacViews: Implement Full Keyboard Access.

ui/views/cocoa/bridged_native_widget.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <objc/runtime.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 333 matching lines @@
   // tied to the C++ object, rather than the delegate (which may be reference
   // counted). This is required since the application hides do not send an
   // orderOut: to individual windows. Unhide, however, does send an order
   // message.
   [[NSNotificationCenter defaultCenter]
       addObserver:window_delegate_
          selector:@selector(onWindowOrderChanged:)
              name:NSApplicationDidHideNotification
            object:nil];
 
+  // Get notified whenever Full Keyboard Access mode is changed.
+  // Todo(karandeepb): See how to store constant string.

[tapted, 2016/02/23 03:01:19]

You can just declare a

NSString* const kFullKeyboardAccessChangedNotification =
    @"com.apple.KeyboardUIModeDidChange";

in an anonymous namespace

[karandeepb, 2016/03/15 02:19:50]

Done.

+  [[NSDistributedNotificationCenter defaultCenter]
+      addObserver:window_delegate_
+         selector:@selector(onFullKeyboardAccessModeChanged:)
+             name:@"com.apple.KeyboardUIModeDidChange"
+           object:nil];
+
   // Validate the window's initial state, otherwise the bridge's initial
   // tracking state will be incorrect.
   DCHECK(![window_ isVisible]);
   DCHECK_EQ(0u, [window_ styleMask] & NSFullScreenWindowMask);
 
   if (params.parent) {
     // Disallow creating child windows of views not currently in an NSWindow.
     CHECK([params.parent window]);
     BridgedNativeWidget* bridged_native_widget_parent =
         NativeWidgetMac::GetBridgeForNativeWindow([params.parent window]);
@@ skipping 55 matching lines @@
   tooltip_manager_.reset(new TooltipManagerMac(this));
 }
 
 void BridgedNativeWidget::SetFocusManager(FocusManager* focus_manager) {
   if (focus_manager_ == focus_manager)
     return;
 
   if (focus_manager_)
     focus_manager_->RemoveFocusChangeListener(this);
 
-  if (focus_manager)
+  if (focus_manager) {
     focus_manager->AddFocusChangeListener(this);
+    focus_manager->SetKeyboardAccessibility(
+        [NSApp isFullKeyboardAccessEnabled]);
+  }
 
   focus_manager_ = focus_manager;
 }
 
 void BridgedNativeWidget::SetBounds(const gfx::Rect& new_bounds) {
   Widget* widget = native_widget_mac_->GetWidget();
   // -[NSWindow contentMinSize] is only checked by Cocoa for user-initiated
   // resizes. This is not what toolkit-views expects, so clamp. Note there is
   // no check for maximum size (consistent with aura::Window::SetBounds()).
   gfx::Size clamped_content_size =
@@ skipping 148 matching lines @@
   [window_delegate_ setCursor:cursor];
 }
 
 void BridgedNativeWidget::OnWindowWillClose() {
   if (parent_) {
     parent_->RemoveChildWindow(this);
     parent_ = nullptr;
   }
   [window_ setDelegate:nil];
   [[NSNotificationCenter defaultCenter] removeObserver:window_delegate_];
+  [[NSDistributedNotificationCenter defaultCenter]
+      removeObserver:window_delegate_];
   native_widget_mac_->OnWindowWillClose();
 }
 
 void BridgedNativeWidget::OnFullscreenTransitionStart(
     bool target_fullscreen_state) {
   // Note: This can fail for fullscreen changes started externally, but a user
   // shouldn't be able to do that if the window is invisible to begin with.
   DCHECK(window_visible_);
 
   DCHECK_NE(target_fullscreen_state, target_fullscreen_state_);
@@ skipping 142 matching lines @@
 }
 
 void BridgedNativeWidget::OnWindowKeyStatusChangedTo(bool is_key) {
   Widget* widget = native_widget_mac()->GetWidget();
   widget->OnNativeWidgetActivationChanged(is_key);
   // The contentView is the BridgedContentView hosting the views::RootView. The
   // focus manager will already know if a native subview has focus.
   if ([window_ contentView] == [window_ firstResponder]) {
     if (is_key) {
       widget->OnNativeFocus();
+      // The NSApplication class automatically suspends distributed notification
+      // delivery when the application is not active. For the full keyboard
+      // access mode change notification, the default suspension behavior of
+      // NSNotificationSuspensionBehaviorCoalesce should have worked, but
+      // it doesn't sometimes. Hence explicitly set the keyboard accessibility
+      // state on regaining key window status.
+      widget->GetFocusManager()->SetKeyboardAccessibility(
+          [NSApp isFullKeyboardAccessEnabled]);
       widget->GetFocusManager()->RestoreFocusedView();
     } else {
       widget->OnNativeBlur();
       widget->GetFocusManager()->StoreFocusedView(true);
     }
   }
 }
 
 bool BridgedNativeWidget::ShouldRepostPendingLeftMouseDown(
     NSPoint location_in_window) {
@@ skipping 467 matching lines @@
   [bridged_view_ setMouseDownCanMoveWindow:draggable];
   // AppKit will not update its cache of mouseDownCanMoveWindow unless something
   // changes. Previously we tried adding an NSView and removing it, but for some
   // reason it required reposting the mouse-down event, and didn't always work.
   // Calling the below seems to be an effective solution.
   [window_ setMovableByWindowBackground:NO];
   [window_ setMovableByWindowBackground:YES];
 }
 
 }  // namespace views