MacViews: Implement Full Keyboard Access.

chrome/browser/ui/views/download/download_shelf_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_shelf_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 22 matching lines @@
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/vector_icons_public.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/mouse_watcher_view_host.h"
+#include "ui/views/style/platform_style.h"
 
 using content::DownloadItem;
 
 namespace {
 
 // Max number of download views we'll contain. Any time a view is added and
 // we already have this many download views, one is removed.
 const size_t kMaxDownloadViews = 15;
 
 // Padding from left edge and first download view.
@@ skipping 105 matching lines @@
     close_button_ = new views::ImageButton(this);
     close_button_->SetImage(views::CustomButton::STATE_NORMAL,
                             rb.GetImageSkiaNamed(IDR_CLOSE_1));
     close_button_->SetImage(views::CustomButton::STATE_HOVERED,
                             rb.GetImageSkiaNamed(IDR_CLOSE_1_H));
     close_button_->SetImage(views::CustomButton::STATE_PRESSED,
                             rb.GetImageSkiaNamed(IDR_CLOSE_1_P));
   } else {
     views::LabelButton* show_all_view = new views::LabelButton(
         this, l10n_util::GetStringUTF16(IDS_SHOW_ALL_DOWNLOADS_MD));
-    show_all_view->SetFocusable(true);

[tapted, 2016/02/23 03:01:19]

SetControlStyleFocus instead?

[karandeepb, 2016/03/15 02:19:50]

This call is redundant, since SetStyle(..) on the next line calls
SetFocusable(true).

     show_all_view->SetStyle(views::Button::STYLE_BUTTON);
     show_all_view_ = show_all_view;
 
     BarControlButton* close_button = new BarControlButton(this);
     close_button->SetIcon(gfx::VectorIconId::BAR_CLOSE,
                           base::Bind(&DownloadShelfView::GetTextColorForIconMd,
                                      base::Unretained(this)));
     close_button_ = close_button;
   }
   close_button_->SetAccessibleName(
@@ skipping 311 matching lines @@
 
 content::DownloadItem* DownloadShelfView::GetDownloadItemForView(size_t i) {
   if (ui::MaterialDesignController::IsModeMaterial())
     return static_cast<DownloadItemViewMd*>(download_views_[i])->download();
   return static_cast<DownloadItemView*>(download_views_[i])->download();
 }
 
 SkColor DownloadShelfView::GetTextColorForIconMd() {
   return DownloadItemViewMd::GetTextColorForThemeProvider(GetThemeProvider());
 }