Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1690543003: Revert of Make text section 2MB aligned for hugepages. (patchset #7 id:120001 of https://codereview… (Closed)

Created:
4 years, 10 months ago by stevenjb
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2645
Target Ref:
refs/pending/branch-heads/2645
Project:
chromium
Visibility:
Public.

Description

Revert of Make text section 2MB aligned for hugepages. (patchset #7 id:120001 of https://codereview.chromium.org/1619713007/ ) Reason for revert: Causing failures on x86-alex, peach_pit, and daisy_skate (render process crash in login screen). Original issue's description: > Make text section 2MB aligned for hugepages. > > If we do not use the option '-Wl,--section-start=.text=2001000' at > link time, the performance gain on hugepages is gone. This is probably > because the original text section is not 2MB aligned and the after > mremap, the hugepage is not preserved. > > BUG=chromium:569963 > TEST=The performance gain is back on micro benchmarks. > > Committed: https://crrev.com/1384534a94e6324d74906f0cbc1e707606c063f2 > Cr-Commit-Position: refs/heads/master@{#373673} TBR=rickyz@chromium.org,cmtice@chromium.org,kenchen@google.com,llozano@chromium.org,shenhan@chromium.org,yunlian@chromium.org,yunlian@chromium.org BUG=chromium:569963 Review URL: https://codereview.chromium.org/1687033002 Cr-Commit-Position: refs/heads/master@{#374687} (cherry picked from commit f0aab631c727924fb1ae2ff9e6ba5878c073b717) Committed: https://chromium.googlesource.com/chromium/src/+/1c19dc1b4ca8d047819ec63752bbfb4519aedd93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chromeos/hugepage_text/hugepage_text.cc View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
stevenjb
Committed patchset #1 (id:1) manually as 1c19dc1b4ca8d047819ec63752bbfb4519aedd93.
4 years, 10 months ago (2016-02-10 18:40:16 UTC) #2
rickyz (no longer on Chrome)
4 years, 10 months ago (2016-02-10 21:55:24 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698