third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp - Issue 1690543002: Add additive animation support for CSS properties perspective-origin and object-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

Issue 1690543002: Add additive animation support for CSS properties perspective-origin and object-position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_backgroundPositionAnimation

Patch Set: Remove from StringKeyframe Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html ('K') | « third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

index 0bb78e13d797d231357a19f72a1ad918151ff686..ccae56dc3fae6b5298073d6dbd3120033d771175 100644

--- a/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

@@ -59,6 +59,13 @@ PassOwnPtr<InterpolableValue> CSSLengthInterpolationType::createInterpolablePixe

return interpolableList.release();

}

+InterpolationValue CSSLengthInterpolationType::createInterpolablePercent(double percent)

+ OwnPtr<InterpolableList> interpolableList = createNeutralInterpolableValue();

+ interpolableList->set(CSSPrimitiveValue::UnitTypePercentage, InterpolableNumber::create(percent));

+ return InterpolationValue(interpolableList.release(), CSSLengthNonInterpolableValue::create(true));

InterpolationValue CSSLengthInterpolationType::maybeConvertLength(const Length& length, float zoom)

{

if (!length.isSpecified())