Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1690533002: Turn firstPaint and firstContentfulPaint into instant trace events (Closed)

Created:
4 years, 10 months ago by Kunihiko Sakamoto
Modified:
4 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn firstPaint and firstContentfulPaint into instant trace events Record blink.user_timing.{firstPaint, firstContentfulPaint} as process-wide instant trace-events, in order to make them easier to find in trace viewer. BUG=546448 Committed: https://crrev.com/53413eca47e43fe3420d2d1a8bf6507810584d23 Cr-Commit-Position: refs/heads/master@{#374621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Kunihiko Sakamoto
4 years, 10 months ago (2016-02-10 06:18:54 UTC) #4
kinuko
lgtm
4 years, 10 months ago (2016-02-10 06:45:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690533002/1
4 years, 10 months ago (2016-02-10 06:49:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 07:46:51 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 07:49:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53413eca47e43fe3420d2d1a8bf6507810584d23
Cr-Commit-Position: refs/heads/master@{#374621}

Powered by Google App Engine
This is Rietveld 408576698