Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
169053007:
Add a compile-only config to chromium_trybot (Closed)
|
Created:
6 years, 10 months ago by Paweł Hajdan Jr. Modified:
6 years, 10 months ago Reviewers:
agable CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org Visibility:
Public. |
DescriptionAdd a compile-only config to chromium_trybot
This is needed for the CQ.
BUG=317931
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=251923
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 10 (0 generated)
lgtm https://codereview.chromium.org/169053007/diff/1/scripts/slave/recipes/chromi... File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/169053007/diff/1/scripts/slave/recipes/chromi... scripts/slave/recipes/chromium_trybot.py:84: 'compile': { Seems like we can probably have a more descriptive name than that?
https://codereview.chromium.org/169053007/diff/1/scripts/slave/recipes/chromi... File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/169053007/diff/1/scripts/slave/recipes/chromi... scripts/slave/recipes/chromium_trybot.py:84: 'compile': { On 2014/02/19 01:56:26, agable wrote: > Seems like we can probably have a more descriptive name than that? Not sure what would be better. Keeping it short seems to also help. I think it fits well with other names here, but I'm open to specific suggestions what the name should be.
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/169053007/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 169053007-1 failed and returned exit status 1.
Running presubmit commit checks ...
** Presubmit ERRORS **
scripts/slave/unittests/recipes_test.py (15.30s) failed
........................................................................E.......................................................................................................................
======================================================================
ERROR: test_compile (__main__.RecipeTest_for_chromium_trybot)
----------------------------------------------------------------------
Traceback (most recent call last):
File "scripts/slave/unittests/recipes_test.py", line 153, in test_
IOError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile.json'
----------------------------------------------------------------------
Ran 192 tests in 11.856s
FAILED (errors=1)
Name
Stmts Miss Cover Missing
--------------------------------------------------------------------------------------------------------------------------
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/android/api
71 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/android/test_api
4 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/archive/api
29 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/base_android/api
25 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/buildbot/api
4 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/chromite/api
22 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/chromium/api
114 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/chromium_android/api
162 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/chromium_android/test_api
4 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/gclient/api
113 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/gclient/test_api
11 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/generator_script/api
32 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/generator_script/test_api
5 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/git/api
28 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/gpu/api
81 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/gpu/test_api
5 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/gsutil/api
20 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/isolate/api
30 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/isolate/test_api
4 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/itertools/api
9 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/json/api
78 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/json/test_api
35 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/path/api
102 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/path/test_api
9 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/platform/api
33 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/platform/test_api
12 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/properties/api
26 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/properties/test_api
22 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/python/api
16 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/raw_io/api
34 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/raw_io/test_api
1 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/repo/api
17 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/rietveld/api
9 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/skia/api
20 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/step/api
30 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/step_history/api
13 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/test_utils/api
43 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/tryserver/api
7 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/v8/api
17 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipe_modules/webrtc/api
15 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/android/android_builder
35 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/android/instrumentation_tests
29 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/android_webview_aosp
21 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/blink_trybot
65 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/chromium
74 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/chromium_trybot
173 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/dart/dartium
46 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/gatekeeper
6 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/gatekeeper-failure
8 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/gpu/build_and_test
22 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/gpu/build_and_upload
12 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/gpu/download_and_test
15 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/libvpx_android_unittests
27 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/oilpan
38 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/ozone_ecs
24 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/polymer
41 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/run_presubmit
19 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/skia/build_and_test
10 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/v8
15 0 100%
/b/commit-queue/workdir/tools/build/scripts/slave/recipes/webrtc_android_apk_trybot
21 0 100%
--------------------------------------------------------------------------------------------------------------------------
TOTAL
2013 0 100%
Presubmit checks took 41.1s to calculate.
The CQ bit was checked by phajdan.jr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/169053007/100001
Message was sent while issue was closed.
Change committed as 251923 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
