Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle

Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle

XMLHttpRequestProgressEvent is no more.

BUG=357112
R=chrishtr@chromium.org

Committed: https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974
Cr-Commit-Position: refs/heads/master@{#374683}

[philipj_slow, 2016-02-10 04:40:48]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 04:41:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690503002/1

[commit-bot: I haz the power, 2016-02-10 06:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 06:03:18]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-02-10 07:35:00]

tyoshino@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-02-10 07:35:01]

This class is dedicated for the XMLHttpRequest. I'd parse the name as [
XMLHttpRequest 's ProgressEvent Throttle ]. Not [ XMLHttpRequestProgressEvent
Throttle ].

So, I think it's fine to leave this named as-is.

If we merge some of EventSource, Fetch API, XHR, sendBeacon, ... into one
directory in the future, it's better to have the prefix, I think.

[chrishtr, 2016-02-10 17:48:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-02-10 17:48:04]

lgtm

[commit-bot: I haz the power, 2016-02-10 17:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690503002/1

[commit-bot: I haz the power, 2016-02-10 17:56:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 17:58:39]

Description was changed from

==========
Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle

XMLHttpRequestProgressEvent is no more.

BUG=357112
R=chrishtr@chromium.org
==========

to

==========
Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle

XMLHttpRequestProgressEvent is no more.

BUG=357112
R=chrishtr@chromium.org

Committed: https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974
Cr-Commit-Position: refs/heads/master@{#374683}
==========

[commit-bot: I haz the power, 2016-02-10 17:58:40]

Patchset 1 (id:??) landed as
https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974
Cr-Commit-Position: refs/heads/master@{#374683}

[philipj_slow, 2016-02-11 14:46:25]

Oops, chrishtr@, did you read tyoshino@'s comments? Revert?

FWIW, I've been thinking for a while that FormmData and ProgressEvent should
move into the XHR code, as that's where it lives in spec land:
https://xhr.spec.whatwg.org/#interface-formdata
https://xhr.spec.whatwg.org/#interface-progressevent

tyoshino@, if ProgressEvent is moved here as well, do you think it would make
more sense?

[chrishtr, 2016-02-11 16:06:52]

On 2016/02/11 at 14:46:25, philipj wrote:
> Oops, chrishtr@, did you read tyoshino@'s comments? Revert?

 I missed those comments. Let's revert.

> 
> FWIW, I've been thinking for a while that FormmData and ProgressEvent should
move into the XHR code, as that's where it lives in spec land:
> https://xhr.spec.whatwg.org/#interface-formdata
> https://xhr.spec.whatwg.org/#interface-progressevent
> 
> tyoshino@, if ProgressEvent is moved here as well, do you think it would make
more sense?

[chrishtr, 2016-02-11 16:07:11]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1686953006/ by chrishtr@chromium.org.

The reason for reverting is: More discussion is needed about these class names..

[philipj_slow, 2016-02-15 11:10:15]

On 2016/02/11 16:07:11, chrishtr wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1686953006/ by mailto:chrishtr@chromium.org.
> 
> The reason for reverting is: More discussion is needed about these class
names..

So, I suppose I'll just leave this alone now, at least until (if) ProgressEvent
moves in with core/xmlhttprequest/

[tyoshino (SeeGerritForStatus), 2016-02-17 06:11:15]

On 2016/02/11 at 14:46:25, philipj wrote:
> Oops, chrishtr@, did you read tyoshino@'s comments? Revert?
> 
> FWIW, I've been thinking for a while that FormmData and ProgressEvent should
move into the XHR code, as that's where it lives in spec land:
> https://xhr.spec.whatwg.org/#interface-formdata
> https://xhr.spec.whatwg.org/#interface-progressevent
> 
> tyoshino@, if ProgressEvent is moved here as well, do you think it would make
more sense?

Ah, I see. Yeah, the functionality of the ProgressEvent itself is not dedicated
for the XMLHttpRequest (ProgressEvent.h and .cpp are XHR free), but in fact it
has only one customer which is XHR.

Once ProgressEvent is moved to under core/xmlhttprequest, I'm fine with sticking
the naming rule to ProgressEvent.cpp (i.e. renaming it to
ProgressEventThrottle.cpp) than the idea that the throttle is dedicated for
XMLHttpRequest (in terms of both spec and implementation).

Thanks, philipj, chrishtr!