Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1690503002: Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename XMLHttpRequestProgressEventThrottle to ProgressEventThrottle XMLHttpRequestProgressEvent is no more. BUG=357112 R=chrishtr@chromium.org Committed: https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974 Cr-Commit-Position: refs/heads/master@{#374683}

Patch Set 1 #

Messages

Total messages: 18 (5 generated)
philipj_slow
4 years, 10 months ago (2016-02-10 04:40:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690503002/1
4 years, 10 months ago (2016-02-10 04:41:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 06:03:18 UTC) #5
tyoshino (SeeGerritForStatus)
This class is dedicated for the XMLHttpRequest. I'd parse the name as [ XMLHttpRequest 's ...
4 years, 10 months ago (2016-02-10 07:35:01 UTC) #7
chrishtr
lgtm
4 years, 10 months ago (2016-02-10 17:48:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690503002/1
4 years, 10 months ago (2016-02-10 17:48:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 17:56:15 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b252bda4c2fdefef8c4a8508b6c246573f0c7974 Cr-Commit-Position: refs/heads/master@{#374683}
4 years, 10 months ago (2016-02-10 17:58:40 UTC) #13
philipj_slow
Oops, chrishtr@, did you read tyoshino@'s comments? Revert? FWIW, I've been thinking for a while ...
4 years, 10 months ago (2016-02-11 14:46:25 UTC) #14
chrishtr
On 2016/02/11 at 14:46:25, philipj wrote: > Oops, chrishtr@, did you read tyoshino@'s comments? Revert? ...
4 years, 10 months ago (2016-02-11 16:06:52 UTC) #15
chrishtr
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1686953006/ by chrishtr@chromium.org. ...
4 years, 10 months ago (2016-02-11 16:07:11 UTC) #16
philipj_slow
On 2016/02/11 16:07:11, chrishtr wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 10 months ago (2016-02-15 11:10:15 UTC) #17
tyoshino (SeeGerritForStatus)
4 years, 10 months ago (2016-02-17 06:11:15 UTC) #18
Message was sent while issue was closed.
On 2016/02/11 at 14:46:25, philipj wrote:
> Oops, chrishtr@, did you read tyoshino@'s comments? Revert?
> 
> FWIW, I've been thinking for a while that FormmData and ProgressEvent should
move into the XHR code, as that's where it lives in spec land:
> https://xhr.spec.whatwg.org/#interface-formdata
> https://xhr.spec.whatwg.org/#interface-progressevent
> 
> tyoshino@, if ProgressEvent is moved here as well, do you think it would make
more sense?

Ah, I see. Yeah, the functionality of the ProgressEvent itself is not dedicated
for the XMLHttpRequest (ProgressEvent.h and .cpp are XHR free), but in fact it
has only one customer which is XHR.

Once ProgressEvent is moved to under core/xmlhttprequest, I'm fine with sticking
the naming rule to ProgressEvent.cpp (i.e. renaming it to
ProgressEventThrottle.cpp) than the idea that the throttle is dedicated for
XMLHttpRequest (in terms of both spec and implementation).

Thanks, philipj, chrishtr!

Powered by Google App Engine
This is Rietveld 408576698