Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/core.gyp

Issue 1690493002: Switch to LayoutThemeMobile when emulating mobile device in DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more mac compile Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/core.gyp
diff --git a/third_party/WebKit/Source/core/core.gyp b/third_party/WebKit/Source/core/core.gyp
index ef668daf6194e9f00d6768301f158d4ac1cf6163..27f1a0b281ea5f510292dce4d042c76c8b808bc2 100644
--- a/third_party/WebKit/Source/core/core.gyp
+++ b/third_party/WebKit/Source/core/core.gyp
@@ -430,13 +430,11 @@
['OS=="win" and buildtype=="Official"', {
'msvs_shard': 5,
}],
- ['use_default_render_theme==0 and OS != "android"', {
+ ['OS=="win"', {
'sources!': [
- 'layout/LayoutThemeDefault.cpp',
- 'layout/LayoutThemeDefault.h',
+ 'layout/LayoutThemeFontProviderDefault.cpp',
],
- }],
- ['OS!="win"', {
+ },{ # OS!="win"
'sources!': [
'layout/LayoutThemeFontProviderWin.cpp',
'layout/LayoutThemeWin.cpp',
@@ -448,13 +446,7 @@
['include', '<(DEPTH)/third_party/WebKit/Source/build/win/Precompile.cpp'],
],
}],
- ['OS=="mac"', {
- 'sources!': [
- # LayoutThemeFontProvider is used by LayoutThemeDefault.
- 'layout/LayoutThemeFontProvider.cpp',
- 'layout/LayoutThemeFontProvider.h',
- ],
- },{ # OS!="mac"
+ ['OS!="mac"', {
'sources!': [
'layout/LayoutThemeMac.h',
'layout/LayoutThemeMac.mm',
@@ -466,11 +458,6 @@
'layout/LayoutThemeLinux.h',
],
}],
- ['OS != "linux" and OS != "android"', {
- 'sources!': [
- 'layout/LayoutThemeFontProviderLinux.cpp',
- ],
- }],
['OS!="android"', {
'sources!': [
'layout/LayoutThemeAndroid.cpp',
@@ -532,12 +519,6 @@
['include', '<(DEPTH)/third_party/WebKit/Source/build/win/Precompile.cpp'],
],
}],
- ['use_default_render_theme==0 and OS != "android"', {
- 'sources!': [
- 'paint/ThemePainterDefault.cpp',
- 'paint/ThemePainterDefault.h',
- ],
- }],
],
# Disable c4267 warnings until we fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, 4334, ],
@@ -723,14 +704,6 @@
'testing/v8',
],
'conditions': [
- ['use_default_render_theme==0 and OS != "android"', {
- 'sources!': [
- 'layout/LayoutThemeDefault.cpp',
- 'layout/LayoutThemeDefault.h',
- 'paint/ThemePainterDefault.cpp',
- 'paint/ThemePainterDefault.h',
- ],
- }],
['OS=="win"', {
# In generated bindings code: 'switch contains default but no
# case'.
@@ -750,6 +723,9 @@
},
},
},
+ 'sources!': [
+ 'layout/LayoutThemeFontProviderDefault.cpp',
+ ],
}, {
'sources!': [
'layout/LayoutThemeFontProviderWin.cpp',
@@ -766,16 +742,6 @@
],
}],
['OS=="mac"', {
- 'sources!': [
- # LayoutThemeSkia is not used on mac since LayoutThemeMac
- # does not reference the Skia code that is used by Windows, Linux and Android.
- 'layout/LayoutThemeSkia.cpp',
- 'layout/LayoutThemeSkia.h',
-
- # LayoutThemeFontProvider is used by LayoutThemeSkia.
- 'layout/LayoutThemeFontProvider.cpp',
- 'layout/LayoutThemeFontProvider.h',
- ],
'link_settings': {
'libraries': [
'$(SDKROOT)/System/Library/Frameworks/Carbon.framework',
@@ -794,11 +760,6 @@
'layout/LayoutThemeLinux.h',
],
}],
- ['OS != "linux" and OS != "android"', {
- 'sources!': [
- 'layout/LayoutThemeFontProviderLinux.cpp',
- ],
- }],
['OS=="android"', {
'cflags': [
# WebCore does not work with strict aliasing enabled.

Powered by Google App Engine
This is Rietveld 408576698