Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1690483002: Fixed point sizes > 1 on desktop OpenGL Core Profile. (Closed)

Created:
4 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, piman+watch_chromium.org, Dean McNamee, Geoff Lang, Jamie Madill, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed point sizes > 1 on desktop OpenGL Core Profile. BUG=558738 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1a50fa32b006698d5b5bdfc909c9d1470e12522a Cr-Commit-Position: refs/heads/master@{#374823}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Ken Russell (switch to Gerrit)
PTAL I'll add a more stringent WebGL 2.0 conformance test that would have caught this ...
4 years, 10 months ago (2016-02-10 02:05:57 UTC) #3
Zhenyao Mo
On 2016/02/10 02:05:57, Ken Russell wrote: > PTAL > > I'll add a more stringent ...
4 years, 10 months ago (2016-02-10 17:09:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690483002/1
4 years, 10 months ago (2016-02-10 17:12:29 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/21377)
4 years, 10 months ago (2016-02-10 20:10:18 UTC) #8
Ken Russell (switch to Gerrit)
I verified that the existing conformance/glsl/variables/gl-pointcoord.html test would have caught this failure well. Rather than ...
4 years, 10 months ago (2016-02-11 00:07:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690483002/20001
4 years, 10 months ago (2016-02-11 00:08:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 01:27:48 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a50fa32b006698d5b5bdfc909c9d1470e12522a
Cr-Commit-Position: refs/heads/master@{#374823}

Powered by Google App Engine
This is Rietveld 408576698