Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1690443002: Linux - fix native theme selection during theme changes (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux - fix native theme selection during theme changes this is a revert of a change I made here: https://codereview.chromium.org/1637203002/diff/60001/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc BUG=585522 Committed: https://crrev.com/1aad8a3df92788896c63ca7079f4dc2ef053fe3c Cr-Commit-Position: refs/heads/master@{#374735}

Patch Set 1 #

Patch Set 2 : the indentation was too damn high #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 1 chunk +13 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Evan Stade
4 years, 10 months ago (2016-02-10 01:04:07 UTC) #3
Evan Stade
PS1 is the meat of the change, PS2 is just a readability improvement.
4 years, 10 months ago (2016-02-10 01:06:41 UTC) #4
Elliot Glaysher
lgtm
4 years, 10 months ago (2016-02-10 01:14:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690443002/20001
4 years, 10 months ago (2016-02-10 01:28:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144546)
4 years, 10 months ago (2016-02-10 01:42:57 UTC) #9
Evan Stade
over to Scott for owners
4 years, 10 months ago (2016-02-10 01:59:35 UTC) #11
sky
LGTM
4 years, 10 months ago (2016-02-10 16:42:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690443002/20001
4 years, 10 months ago (2016-02-10 21:42:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 21:51:39 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:22 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1aad8a3df92788896c63ca7079f4dc2ef053fe3c
Cr-Commit-Position: refs/heads/master@{#374735}

Powered by Google App Engine
This is Rietveld 408576698