Issue 16904003: SkHello for NaCl

Issue 16904003: SkHello for NaCl (Closed)

Created:
7 years, 6 months ago by borenet

Modified:
7 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

SkHello for NaCl Not ready to submit. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9639

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -106 lines)			Patch
M	Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	1 2	1 chunk	+15 lines, -5 lines	0 comments	Download
M	platform_tools/nacl/index.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	platform_tools/nacl/skhello/index.html	View	1	4 chunks	+5 lines, -12 lines	0 comments	Download
A	platform_tools/nacl/skhello/skhello.nmf	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	platform_tools/nacl/src/nacl_hello.cpp	View		5 chunks	+18 lines, -89 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

https://codereview.chromium.org/16904003/diff/4001/Makefile File Makefile (right): https://codereview.chromium.org/16904003/diff/4001/Makefile#newcode48 Makefile:48: skhello \ We don't want to do this, but ...

7 years, 6 months ago (2013-06-17 13:47:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/16904003/11001

7 years, 6 months ago (2013-06-17 15:36:38 UTC) #3

commit-bot: I haz the power

Failed to apply patch for platform_tools/nacl/skhello/index.html: While running patch -p0 --forward --force --no-backup-if-mismatch; A platform_tools/nacl/skhello ...

7 years, 6 months ago (2013-06-17 15:36:40 UTC) #4

Failed to apply patch for platform_tools/nacl/skhello/index.html:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  A         platform_tools/nacl/skhello
  Created missing directory platform_tools/nacl/skhello.
  can't find file to patch at input line 5
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: platform_tools/nacl/skhello/index.html
  |===================================================================
  |--- platform_tools/nacl/skhello/index.html	(revision 0)
  |+++ platform_tools/nacl/skhello/index.html	(working copy)
  --------------------------
  No file to patch.  Skipping patch.
  4 out of 4 hunks ignored

Patch:   N   platform_tools/nacl/skhello/index.html
Index: platform_tools/nacl/skhello/index.html
===================================================================
--- platform_tools/nacl/skhello/index.html	(revision 0)
+++ platform_tools/nacl/skhello/index.html	(working copy)
@@ -8,7 +8,7 @@
   -->
 <head>
 
-  <title>Skia Unit Tests</title>
+  <title>Skia Hello World</title>
 
   <script type="text/javascript">
     "use strict";
@@ -32,11 +32,7 @@
       var skdebugf_cmd = "SkDebugf:";
       if (message_event.data.indexOf(skdebugf_cmd) == 0) {
         var msg_contents = message_event.data.slice(skdebugf_cmd.length)
-        //console.log("Skia: " + msg_contents);
-        var log_textarea = document.getElementById("log_textarea")
-        log_textarea.value += msg_contents;
-        log_textarea.scrollTop = log_textarea.scrollHeight;
-        refresh(log_textarea);
+        console.log("Skia: " + msg_contents);
       } else {
         alert(message_event.data);
       }
@@ -55,11 +51,8 @@
 </head>
 <body>
 
-<h1>Skia Unit Tests</h1>
+<h1>Skia Hello World</h1>
 <p>
-<textarea id="log_textarea" rows="2" cols="2" readonly style="width:100%;
height:500px; resize:none;"></textarea>
-</p>
-<p>
   <div id="listener">
     <script type="text/javascript">
       var listener = document.getElementById('listener');
@@ -69,8 +62,8 @@
 
     <embed name="nacl_module"
        id="skia_nacl"
-       width=0 height=0
-       src="tests.nmf"
+       width=300 height=300
+       src="skhello.nmf"
        type="application/x-nacl" />
   </div>
 </p>

borenet

7 years, 6 months ago (2013-06-17 15:39:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r9639 (presubmit successful).

Expand Messages | Collapse Messages