Source/core/inspector/InspectorFileSystemAgent.cpp - Issue 16904002: Avoid leaking objects between isolated worlds via attribute event listeners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorFileSystemAgent.cpp

Issue 16904002: Avoid leaking objects between isolated worlds via attribute event listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorFileSystemAgent.cpp

diff --git a/Source/core/inspector/InspectorFileSystemAgent.cpp b/Source/core/inspector/InspectorFileSystemAgent.cpp

index 2fb4a94af6cdca7c15a5cf1922653647c454d3d9..8ce0e381c42f48f0e504ee660fc80fa8ae8c95cb 100644

--- a/Source/core/inspector/InspectorFileSystemAgent.cpp

+++ b/Source/core/inspector/InspectorFileSystemAgent.cpp

@@ -492,8 +492,8 @@ bool FileContentRequest::didGetEntry(Entry* entry)

bool FileContentRequest::didGetFile(File* file)

{

RefPtr<Blob> blob = file->slice(m_start, m_end);

- m_reader->setOnload(this);

- m_reader->setOnerror(this);

+ m_reader->setOnload(this, 0);

+ m_reader->setOnerror(this, 0);

m_reader->readAsArrayBuffer(blob.get(), IGNORE_EXCEPTION);

return true;