Avoid leaking objects between isolated worlds via attribute event listeners

Source/bindings/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 415 matching lines @@
 {
     if (!DOMWrapperWorld::isolatedWorldsExist())
         return MainWorld;
     ASSERT(!v8::Context::GetEntered().IsEmpty());
     DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered());
     if (isolatedWorld)
         return IsolatedWorld;
     return MainWorld;
 }
 
+DOMWrapperWorld* worldForIsolate(v8::Isolate* isolate)

[marja, 2013/06/13 13:56:29]

The name is slightly confusing, since this only returns non-NULL isolated worlds
but never the main world. isolateWorldForIsolate instead (there's also:
DOMWrapperWorld::isolatedWorld(...) so it would fit).

[adamk, 2013/06/13 18:55:07]

Renamed to isolatedWorldForIsolate(). Also changed the argument passed
everywhere to EventTarget to be "isolatedWorld", which I think makes all the
code clearer (if more verbose).

+{
+    V8PerIsolateData* data = V8PerIsolateData::from(isolate);
+    if (data->workerDOMDataStore())
+        return 0;
+    if (!DOMWrapperWorld::isolatedWorldsExist())
+        return 0;
+    ASSERT(!v8::Context::GetEntered().IsEmpty());
+    if (DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered()))

[marja, 2013/06/13 13:56:29]

Shorter (instead of these 3 lines):

return DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered());

[adamk, 2013/06/13 18:55:07]

Fixed, this was an artifact of a previous version of the patch.

+        return isolatedWorld;
+    return 0;
+}
+
 } // namespace WebCore