Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 1690353002: media: Remove Vorbis from secure decoder list for Widevine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/widevine/cdm/widevine_cdm_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index a956d00c50fb119e58f3dfda3aaa367ce239bb12..d3a3f4fdde5b76f37d75fcc261cbf55025e25553 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -172,8 +172,8 @@ void ComputeBuiltInPlugins(std::vector<content::PepperPluginInfo>* plugins) {
kWidevineCdmPluginMimeTypeDescription);
// Add the supported codecs as if they came from the component manifest.
+ // This list must match the CDM that is being bundled with Chrome.
Lei Zhang 2016/02/12 21:34:17 Is there any way to test and assert this is true?
xhwang 2016/02/12 21:39:15 We can bundle the manifest file with the CDM. Then
ddorwin 2016/02/12 21:43:32 This should be part of a larger effort to unify th
xhwang 2016/02/12 21:53:16 Agreed. I filed a bug to track this work: https://
std::vector<std::string> codecs;
- codecs.push_back(kCdmSupportedCodecVorbis);
codecs.push_back(kCdmSupportedCodecVp8);
codecs.push_back(kCdmSupportedCodecVp9);
#if defined(USE_PROPRIETARY_CODECS)
« no previous file with comments | « no previous file | third_party/widevine/cdm/widevine_cdm_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698