Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: Source/core/svg/SVGViewElement.cpp

Issue 169033002: Drop [LegacyImplementedInBaseClass] from SVGFitToViewBox IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGViewElement.h ('k') | Source/core/svg/SVGViewSpec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGViewElement.cpp
diff --git a/Source/core/svg/SVGViewElement.cpp b/Source/core/svg/SVGViewElement.cpp
index 876e10e21ad7d982154e058c649df54004dea8bf..f3dcb445d424d0c76595f1066ed6d764db4a35d9 100644
--- a/Source/core/svg/SVGViewElement.cpp
+++ b/Source/core/svg/SVGViewElement.cpp
@@ -32,14 +32,11 @@ END_REGISTER_ANIMATED_PROPERTIES
inline SVGViewElement::SVGViewElement(Document& document)
: SVGElement(SVGNames::viewTag, document)
- , m_viewBox(SVGAnimatedRect::create(this, SVGNames::viewBoxAttr))
- , m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(this, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio::create()))
+ , SVGFitToViewBox(this)
, m_viewTarget(SVGStaticStringList::create(this, SVGNames::viewTargetAttr))
{
ScriptWrappable::init(this);
- addToPropertyMap(m_viewBox);
- addToPropertyMap(m_preserveAspectRatio);
addToPropertyMap(m_viewTarget);
registerAnimatedPropertiesForSVGViewElement();
}
@@ -67,17 +64,15 @@ void SVGViewElement::parseAttribute(const QualifiedName& name, const AtomicStrin
return;
}
- if (SVGFitToViewBox::parseAttribute(this, name, value))
- return;
- if (SVGZoomAndPan::parseAttribute(name, value))
- return;
-
SVGParsingError parseError = NoError;
- if (name == SVGNames::viewTargetAttr)
+ if (SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
+ } else if (SVGZoomAndPan::parseAttribute(name, value)) {
+ } else if (name == SVGNames::viewTargetAttr) {
m_viewTarget->setBaseValueAsString(value, parseError);
- else
+ } else {
ASSERT_NOT_REACHED();
+ }
reportAttributeParsingError(parseError, name, value);
}
« no previous file with comments | « Source/core/svg/SVGViewElement.h ('k') | Source/core/svg/SVGViewSpec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698