Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: Source/core/svg/SVGSymbolElement.cpp

Issue 169033002: Drop [LegacyImplementedInBaseClass] from SVGFitToViewBox IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGSymbolElement.h ('k') | Source/core/svg/SVGViewElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGSymbolElement.cpp
diff --git a/Source/core/svg/SVGSymbolElement.cpp b/Source/core/svg/SVGSymbolElement.cpp
index f3197c295054053aef5a2ffd0ffe3bdec6a95163..4035b2534c2965a4c0fc3c5f25d471fc025af3d5 100644
--- a/Source/core/svg/SVGSymbolElement.cpp
+++ b/Source/core/svg/SVGSymbolElement.cpp
@@ -36,13 +36,10 @@ END_REGISTER_ANIMATED_PROPERTIES
inline SVGSymbolElement::SVGSymbolElement(Document& document)
: SVGElement(SVGNames::symbolTag, document)
- , m_viewBox(SVGAnimatedRect::create(this, SVGNames::viewBoxAttr))
- , m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(this, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio::create()))
+ , SVGFitToViewBox(this)
{
ScriptWrappable::init(this);
- addToPropertyMap(m_viewBox);
- addToPropertyMap(m_preserveAspectRatio);
registerAnimatedPropertiesForSVGSymbolElement();
}
@@ -67,10 +64,13 @@ void SVGSymbolElement::parseAttribute(const QualifiedName& name, const AtomicStr
return;
}
- if (SVGFitToViewBox::parseAttribute(this, name, value))
- return;
+ SVGParsingError parseError = NoError;
+ if (SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
+ } else {
+ ASSERT_NOT_REACHED();
+ }
- ASSERT_NOT_REACHED();
+ reportAttributeParsingError(parseError, name, value);
}
void SVGSymbolElement::svgAttributeChanged(const QualifiedName& attrName)
« no previous file with comments | « Source/core/svg/SVGSymbolElement.h ('k') | Source/core/svg/SVGViewElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698