Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4072)

Unified Diff: Source/core/svg/SVGPatternElement.cpp

Issue 169033002: Drop [LegacyImplementedInBaseClass] from SVGFitToViewBox IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Further refactoring Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGPatternElement.cpp
diff --git a/Source/core/svg/SVGPatternElement.cpp b/Source/core/svg/SVGPatternElement.cpp
index 095c2f6663997158b957a7f3a9c5daaf89637b8c..373e1805986a3f2349c06f2fa5a11cfaeabdfe48 100644
--- a/Source/core/svg/SVGPatternElement.cpp
+++ b/Source/core/svg/SVGPatternElement.cpp
@@ -47,12 +47,11 @@ END_REGISTER_ANIMATED_PROPERTIES
inline SVGPatternElement::SVGPatternElement(Document& document)
: SVGElement(SVGNames::patternTag, document)
, SVGTests(this)
+ , SVGFitToViewBox(this)
, m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(LengthModeWidth)))
, m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight)))
, m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth)))
, m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight)))
- , m_viewBox(SVGAnimatedRect::create(this, SVGNames::viewBoxAttr))
- , m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(this, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio::create()))
, m_href(SVGAnimatedString::create(this, XLinkNames::hrefAttr, SVGString::create()))
, m_patternUnits(SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX)
, m_patternContentUnits(SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE)
@@ -63,8 +62,6 @@ inline SVGPatternElement::SVGPatternElement(Document& document)
addToPropertyMap(m_y);
addToPropertyMap(m_width);
addToPropertyMap(m_height);
- addToPropertyMap(m_viewBox);
- addToPropertyMap(m_preserveAspectRatio);
addToPropertyMap(m_href);
registerAnimatedPropertiesForSVGPatternElement();
}
@@ -124,8 +121,7 @@ void SVGPatternElement::parseAttribute(const QualifiedName& name, const AtomicSt
m_height->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
else if (name.matches(XLinkNames::hrefAttr))
m_href->setBaseValueAsString(value, parseError);
- else if (SVGTests::parseAttribute(name, value)
- || SVGFitToViewBox::parseAttribute(this, name, value)) {
+ else if (SVGTests::parseAttribute(name, value) || SVGFitToViewBox::parseAttribute(name, value, document(), parseError)) {
} else
ASSERT_NOT_REACHED();

Powered by Google App Engine
This is Rietveld 408576698