Add dart_product binary

Add dart_product binary

- Add dart_product binary that doesn't include the service isolate, Observatory, or the snapshot. It can only be used for running full snapshots.
- Use this binary when running tests.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/7b7f2b05c6d72fbd86fcbd8814b3251df366aa64

[Cutch, 2016-02-12 15:39:01]

Description was changed from

==========
Add dart_product binary

BUG=
==========

to

==========
Add dart_product binary

BUG=
==========

[Cutch, 2016-02-12 15:39:01]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[Cutch, 2016-02-12 15:42:00]

Description was changed from

==========
Add dart_product binary

BUG=
==========

to

==========
Add dart_product binary

- Add dart_product binary that doesn't include the service isolate or
Observatory but still links in the snapshot.
- Use this binary when running tests.
==========

[Cutch, 2016-02-12 17:41:34]

Description was changed from

==========
Add dart_product binary

- Add dart_product binary that doesn't include the service isolate or
Observatory but still links in the snapshot.
- Use this binary when running tests.
==========

to

==========
Add dart_product binary

- Add dart_product binary that doesn't include the service isolate, Observatory,
or the snapshot. It can only be used for running full snapshots.
- Use this binary when running tests.
==========

[siva, 2016-02-12 18:18:02]

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:627: ],
Not sure if there will be a size difference but do we need -rdynamic ?

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:755: (strcmp(script_uri, DART_VM_SERVICE_ISOLATE_NAME) ==
0)) {
I am wondering if we can move all this run_full_snapshot stuff under
DART_PRODUCT_BINARY, do you see a need for running under that option in a
release build? Maybe in the transient state until everything works it maybe be
needed.

[Cutch, 2016-02-12 18:33:44]

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:627: ],
On 2016/02/12 18:18:01, siva wrote:
> Not sure if there will be a size difference but do we need -rdynamic ?

I've removed it and it still appears to work.

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1690303002/diff/40001/runtime/bin/main.cc#new...
runtime/bin/main.cc:755: (strcmp(script_uri, DART_VM_SERVICE_ISOLATE_NAME) ==
0)) {
On 2016/02/12 18:18:02, siva wrote:
> I am wondering if we can move all this run_full_snapshot stuff under
> DART_PRODUCT_BINARY, do you see a need for running under that option in a
> release build? Maybe in the transient state until everything works it maybe be
> needed.

I've made it so this flag only works in the dart_product binary.

[Cutch, 2016-02-12 18:41:45]

https://codereview.chromium.org/1690303002/diff/60001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/1690303002/diff/60001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:588: 'generate_snapshot_file#host',
Removed.

[siva, 2016-02-12 18:49:57]

lgtm

[Cutch, 2016-02-12 19:05:00]

Description was changed from

==========
Add dart_product binary

- Add dart_product binary that doesn't include the service isolate, Observatory,
or the snapshot. It can only be used for running full snapshots.
- Use this binary when running tests.
==========

to

==========
Add dart_product binary

- Add dart_product binary that doesn't include the service isolate, Observatory,
or the snapshot. It can only be used for running full snapshots.
- Use this binary when running tests.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7b7f2b05c6d72fbd86fcbd8814b3251df366aa64
==========

[Cutch, 2016-02-12 19:05:03]

Committed patchset #5 (id:80001) manually as
7b7f2b05c6d72fbd86fcbd8814b3251df366aa64 (presubmit successful).