Add layer name into frame viewer

webkit/renderer/compositor_bindings/web_content_layer_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_CONTENT_LAYER_IMPL_H_
 #define WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_CONTENT_LAYER_IMPL_H_
 
+#include <string>
+
 #include "base/memory/scoped_ptr.h"
 #include "cc/layers/content_layer_client.h"
 #include "third_party/WebKit/public/platform/WebContentLayer.h"
 #include "webkit/renderer/compositor_bindings/web_layer_impl.h"
 #include "webkit/renderer/compositor_bindings/webkit_compositor_bindings_export.h"
 
 namespace cc {
 class IntRect;
 class FloatRect;
 }
 
 namespace WebKit { class WebContentLayerClient; }
 
 namespace webkit {
 
 class WebContentLayerImpl : public WebKit::WebContentLayer,
                             public cc::ContentLayerClient {
  public:
   WEBKIT_COMPOSITOR_BINDINGS_EXPORT explicit WebContentLayerImpl(
       WebKit::WebContentLayerClient*);
 
   // WebContentLayer implementation.
   virtual WebKit::WebLayer* layer();
   virtual void setDoubleSided(bool double_sided);
   virtual void setDrawCheckerboardForMissingTiles(bool checkerboard);
+  std::string DebugName();

[enne (OOO), 2013/07/03 17:40:43]

Is there a reason this is on WebContentLayer and not on WebLayer?

[qiankun, 2013/07/04 04:34:04]

That's due to WebContentLayer is passed as ContentLayerClient when creating
cc::ContentLayer, while WebLayer doesn't have a client. 

[enne (OOO), 2013/07/09 20:15:32]

I don't think WebLayer not having a client is a reason to put this on
WebContentLayerClient.

That said, non-ContentLayers don't really get interesting names:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
(ironically, m_layer ends up being a cc::ContentLayer, m_contentsLayer ends up
being some other non-Content type of layer).

I'd reluctantly be ok with the simplification to only have names for
WebContentLayers, but it seems like this could be more general.

[qiankun, 2013/07/10 04:53:07]

It seems part of WebLayer's behavior is a bridge between WebContentLayer and
cc::Layer. I wonder why WebContentLayer is required, maybe we can implement
WebContentLayer's actions in WebLayer. I keep their current implementations. 

[enne (OOO), 2013/07/10 16:48:42]

WebContentLayer is a logical extension of WebLayer.  It does things that general
WebLayers (and other derived Layer classes) don't need.

 
  protected:
   virtual ~WebContentLayerImpl();
 
   // ContentLayerClient implementation.
   virtual void PaintContents(SkCanvas* canvas,
                              gfx::Rect clip,
                              gfx::RectF* opaque) OVERRIDE;
   virtual void DidChangeLayerCanUseLCDText() OVERRIDE;
 
   scoped_ptr<WebLayerImpl> layer_;
   WebKit::WebContentLayerClient* client_;
   bool draws_content_;
 
  private:
   bool can_use_lcd_text_;
   bool ignore_lcd_text_change_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentLayerImpl);
 };
 
 }  // namespace webkit
 
 #endif  // WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_CONTENT_LAYER_IMPL_H_