Reland "media: Refactor MojoMediaClient" with fix.

Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357, 571155
Committed: https://crrev.com/9e7fb9413f358a2bad6158437b56fa63e50b6f8a
Cr-Commit-Position: refs/heads/master@{#375352}

[xhwang, 2016-02-12 08:21:05]

Current mojo media is a source_set which is directly linked into the dependent
library (e.g. content). Therefore, there's no need to export anything.

In the future, we may consider making media_mojo a component so that it'll be a
shared_library in component build.

[xhwang, 2016-02-12 18:25:06]

xhwang@chromium.org changed reviewers:
+ alokp@chromium.org, jam@chromium.org, thakis@chromium.org

[xhwang, 2016-02-12 18:27:43]

I don't have a Windows environment right now to try this. But I *think* this is
the right fix for now. I added the MEDIA_EXPORT by accident.

As stated earlier, in the future we should probably consider making
media/mojo/services:application a GN "component" rather than a "source_set".

[jam, 2016-02-12 19:20:25]

On 2016/02/12 18:27:43, xhwang wrote:
> I don't have a Windows environment right now to try this. But I *think* this
is
> the right fix for now. I added the MEDIA_EXPORT by accident.
> 
> As stated earlier, in the future we should probably consider making
> media/mojo/services:application a GN "component" rather than a "source_set".

lgtm 

which bot did this break? is there a non-default trybot to check it?

[Nico, 2016-02-12 19:23:25]

On 2016/02/12 19:20:25, jam wrote:
> On 2016/02/12 18:27:43, xhwang wrote:
> > I don't have a Windows environment right now to try this. But I *think* this
> is
> > the right fix for now. I added the MEDIA_EXPORT by accident.
> > 
> > As stated earlier, in the future we should probably consider making
> > media/mojo/services:application a GN "component" rather than a "source_set".
> 
> lgtm 
> 
> which bot did this break? is there a non-default trybot to check it?

It broke the clang/win gn components bot, and I'm guessing normal windows
component builds in gn too. I don't know if we have a "normal" win gn components
build try bot. win_clang_x64_dbg is the opt-in clang/win gn components try bot.

[xhwang, 2016-02-12 22:12:47]

Description was changed from

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

BUG=570357,571155
==========

to

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357,571155
==========

[xhwang, 2016-02-12 22:14:54]

On 2016/02/12 19:23:25, Nico wrote:
> On 2016/02/12 19:20:25, jam wrote:
> > On 2016/02/12 18:27:43, xhwang wrote:
> > > I don't have a Windows environment right now to try this. But I *think*
this
> > is
> > > the right fix for now. I added the MEDIA_EXPORT by accident.
> > > 
> > > As stated earlier, in the future we should probably consider making
> > > media/mojo/services:application a GN "component" rather than a
"source_set".
> > 
> > lgtm 
> > 
> > which bot did this break? is there a non-default trybot to check it?
> 
> It broke the clang/win gn components bot, and I'm guessing normal windows
> component builds in gn too. I don't know if we have a "normal" win gn
components
> build try bot. win_clang_x64_dbg is the opt-in clang/win gn components try
bot.

The win_clang_x64_dbg is still pending. I *think* the fix makes sense so I am
gonna
land this CL. I'll watch the Windows bots after it's landed.

[xhwang, 2016-02-12 22:16:20]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-02-12 22:16:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690213002/20001

[Nico, 2016-02-12 22:17:00]

On 2016/02/12 22:14:54, xhwang wrote:
> On 2016/02/12 19:23:25, Nico wrote:
> > On 2016/02/12 19:20:25, jam wrote:
> > > On 2016/02/12 18:27:43, xhwang wrote:
> > > > I don't have a Windows environment right now to try this. But I *think*
> this
> > > is
> > > > the right fix for now. I added the MEDIA_EXPORT by accident.
> > > > 
> > > > As stated earlier, in the future we should probably consider making
> > > > media/mojo/services:application a GN "component" rather than a
> "source_set".
> > > 
> > > lgtm 
> > > 
> > > which bot did this break? is there a non-default trybot to check it?
> > 
> > It broke the clang/win gn components bot, and I'm guessing normal windows
> > component builds in gn too. I don't know if we have a "normal" win gn
> components
> > build try bot. win_clang_x64_dbg is the opt-in clang/win gn components try
> bot.
> 
> The win_clang_x64_dbg is still pending. I *think* the fix makes sense so I am
> gonna
> land this CL. I'll watch the Windows bots after it's landed.

Would you mind if you waited a bit and I ticked cq tomorrow morning EST? The bot
that broke last time is currently red to something unrelated to this, and I'd
prefer if I could green it up first (I broke it myself this time)

[xhwang, 2016-02-12 22:22:03]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-02-12 22:22:37]

On 2016/02/12 22:17:00, Nico wrote:
> On 2016/02/12 22:14:54, xhwang wrote:
> > On 2016/02/12 19:23:25, Nico wrote:
> > > On 2016/02/12 19:20:25, jam wrote:
> > > > On 2016/02/12 18:27:43, xhwang wrote:
> > > > > I don't have a Windows environment right now to try this. But I
*think*
> > this
> > > > is
> > > > > the right fix for now. I added the MEDIA_EXPORT by accident.
> > > > > 
> > > > > As stated earlier, in the future we should probably consider making
> > > > > media/mojo/services:application a GN "component" rather than a
> > "source_set".
> > > > 
> > > > lgtm 
> > > > 
> > > > which bot did this break? is there a non-default trybot to check it?
> > > 
> > > It broke the clang/win gn components bot, and I'm guessing normal windows
> > > component builds in gn too. I don't know if we have a "normal" win gn
> > components
> > > build try bot. win_clang_x64_dbg is the opt-in clang/win gn components try
> > bot.
> > 
> > The win_clang_x64_dbg is still pending. I *think* the fix makes sense so I
am
> > gonna
> > land this CL. I'll watch the Windows bots after it's landed.
> 
> Would you mind if you waited a bit and I ticked cq tomorrow morning EST? The
bot
> that broke last time is currently red to something unrelated to this, and I'd
> prefer if I could green it up first (I broke it myself this time)

Sure. Thanks for the info!

[jam, 2016-02-12 23:26:40]

On 2016/02/12 22:14:54, xhwang wrote:
> On 2016/02/12 19:23:25, Nico wrote:
> > On 2016/02/12 19:20:25, jam wrote:
> > > On 2016/02/12 18:27:43, xhwang wrote:
> > > > I don't have a Windows environment right now to try this. But I *think*
> this
> > > is
> > > > the right fix for now. I added the MEDIA_EXPORT by accident.
> > > > 
> > > > As stated earlier, in the future we should probably consider making
> > > > media/mojo/services:application a GN "component" rather than a
> "source_set".
> > > 
> > > lgtm 
> > > 
> > > which bot did this break? is there a non-default trybot to check it?
> > 
> > It broke the clang/win gn components bot, and I'm guessing normal windows
> > component builds in gn too. I don't know if we have a "normal" win gn
> components
> > build try bot. win_clang_x64_dbg is the opt-in clang/win gn components try
> bot.
> 
> The win_clang_x64_dbg is still pending. I *think* the fix makes sense so I am
> gonna
> land this CL. I'll watch the Windows bots after it's landed.

in general, if this change got reverted because it broke a bot that's not on the
CQ, i think as Nico suggests it's better to first run the trybot to check that
the fix worked.

[Nico, 2016-02-13 05:43:05]

things are looking pretty good at
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang_x64_db...
; hitting cq now

[Nico, 2016-02-13 05:43:36]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-02-13 05:43:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690213002/20001

[commit-bot: I haz the power, 2016-02-13 05:48:15]

Description was changed from

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357,571155
==========

to

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357,571155
==========

[commit-bot: I haz the power, 2016-02-13 05:48:16]

Committed patchset #2 (id:20001)

[hiroshige, 2016-02-15 17:14:59]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1702453002/ by hiroshige@chromium.org.

The reason for reverting is: Suspected to break a layout test on android.
https://crbug.com/586902.

[commit-bot: I haz the power, 2016-02-16 22:47:34]

Description was changed from

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357,571155
==========

to

==========
Reland "media: Refactor MojoMediaClient" with fix.

This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2.

Instead of specifying a platform based MojoMediaClient at compile time,
provide the capability of setting one at run time. This improves the flexibility
of using MojoMediaApplication in different cases. For example, on desktop, we
may want to run the MojoMediaApplication in the utility process (for the CDM
service) and in the GPU process (for hardware decoding). In those two cases,
we'll want to specify two different MojoMediaClients even though we are on the
same platform.

TBR=alokp@chromium.org
BUG=570357,571155

Committed: https://crrev.com/9e7fb9413f358a2bad6158437b56fa63e50b6f8a
Cr-Commit-Position: refs/heads/master@{#375352}
==========

[commit-bot: I haz the power, 2016-02-16 22:47:35]

Patchset 2 (id:??) landed as
https://crrev.com/9e7fb9413f358a2bad6158437b56fa63e50b6f8a
Cr-Commit-Position: refs/heads/master@{#375352}